Fix Windows CI: pin to windows-2022 (VS2022 toolset)#192
Merged
bkaradzic-microsoft merged 1 commit intoJun 9, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s CMake dependency override to use a newer Microsoft GSL release, addressing Windows/UWP CI failures caused by MSVC VS2026 treating GSL’s [[gsl::suppress]] usage as a /WX-promoted error.
Changes:
- Add a top-level
FetchContent_Declare(GSL ...)to override arcana.cpp’s transitive GSL pin. - Bump the overridden GSL version to
v4.2.2to avoid MSVC C4875 on VS2026 toolsets.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
windows-latest was repointed to a VS2026 toolset whose newer MSVC promotes a GSL [[gsl::suppress]] deprecation (C4875) to an error under /WX, breaking the Win32 and UWP builds. Pin those jobs to windows-2022 so the established VS2022 toolset is used, restoring green CI without a dependency or source change. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bkaradzic-microsoft
force-pushed
the
fix/gsl-bump-c4875
branch
from
e2d45ab to
d4d33db
Compare
bkaradzic-microsoft
changed the title
bghgary
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every Windows/UWP build is failing. GitHub repointed the
windows-latestlabel to a VS2026 toolset (internal imagewindows-2025-vs2026). Its newer MSVC emits C4875 (a non-string literal argument to [[gsl::suppress]] is deprecated) from inside the GSL headers we pull transitively viaarcana.cpp, and our/WXbuilds promote it to a hard error.Fix
Pin the Win32 and UWP jobs to the windows-2022 runner, which still provides the established VS2022 toolset that doesn't emit C4875. This restores green CI with no source or dependency-graph change, and matches the approach taken in BabylonNative (BabylonJS/BabylonNative#1742).
(Originally proposed as a GSL v4.2.2 bump /
/wd4875suppression — see the closed #191 — but pinning the runner is the smaller, decoupled fix and keeps us on the known-good toolchain.)Validation
CI on this branch confirms the Win32/UWP builds are green again on windows-2022.