Skip to content

Re-enable blur-cube-with-the-effect-renderer validation test#1747

Draft
bkaradzic-microsoft wants to merge 1 commit into
BabylonJS:masterfrom
bkaradzic-microsoft:enable-blur-cube-effect-renderer-test
Draft

Re-enable blur-cube-with-the-effect-renderer validation test#1747
bkaradzic-microsoft wants to merge 1 commit into
BabylonJS:masterfrom
bkaradzic-microsoft:enable-blur-cube-effect-renderer-test

Conversation

@bkaradzic-microsoft

Copy link
Copy Markdown
Contributor

Re-enable blur-cube-with-the-effect-renderer validation test

What

Removes the excludeFromAutomaticTesting flag from the
blur-cube-with-the-effect-renderer Playground validation test
(Apps/Playground/Scripts/config.json) so it runs in the automatic suite again.

Why

The test renders an EffectRenderer / EffectWrapper fullscreen pass and used to
produce an all-black frame on Babylon Native, failing the pixel comparison. Root cause
was in the native engine: EffectRenderer disables depth testing through
engine.depthCullingState.depthTest = false, but the native engine only honored depth
state set via the explicit setDepthBuffer() command and never flushed
depthCullingState at draw time (unlike the WebGL/WebGPU applyStates() path). The
fullscreen quad therefore kept the previous draw's depth test and every fragment was
discarded.

Fixed upstream in the native engine:

Depends on the above Babylon.js fix being released and the babylonjs dependency bumped
to a version that contains it. Until then this PR is a draft — CI will only pass once the
updated dependency is in place. (Verified locally against a patched native engine: see
below.)

Verification (local, against the patched native engine)

  • blur-cube-with-the-effect-renderer now runs through the normal path (no
    --include-excluded) and passes:
    Test 'blur-cube-with-the-effect-renderer' validated.
  • Full standard validation sweep: ran=274 passed=274 failed=0 — no regressions, and the
    re-enabled test is included.
  • Scope check: this is the only excluded validation test fixed by the native-engine change
    (the other EffectWrapper-based excluded tests — the Atmosphere * set — still fail for
    unrelated reasons and remain excluded).

This EffectRenderer fullscreen-pass test rendered all-black on Native because the
native engine did not honor depth-test toggles made through
engine.depthCullingState.depthTest (used by EffectRenderer). Fixed upstream in the
native engine (BabylonJS/Babylon.js#18558); re-enable the test here.

Depends on a babylonjs dependency bump that includes the fix.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants