Fix case-sensitive section-name match in sim settings loader#883
Open
samuelduchesne wants to merge 1 commit into
Open
Fix case-sensitive section-name match in sim settings loader#883samuelduchesne wants to merge 1 commit into
samuelduchesne wants to merge 1 commit into
Conversation
`BaseSimSettings.update_from_config` lowercases the section name from the config file but compares it against a list that contains the literal 'Generic Simulation Settings'. As a result, settings under the [Generic Simulation Settings] section were silently skipped, and mandatory settings declared there (e.g. weather_file_path) were never populated — triggering a misleading "not specified" error at run time. Lowercase the literal so the comparison is case-insensitive on both sides.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BaseSimSettings.update_from_configlowercases the section name from the config file but compares it against a list that contains the literal 'Generic Simulation Settings'. As a result, settings under the [Generic Simulation Settings] section were silently skipped, and mandatory settings declared there (e.g. weather_file_path) were never populated — triggering a misleading "not specified" error at run time.Lowercase the literal so the comparison is case-insensitive on both sides.