Conversation
Wind has been tested and works as expected, but external comfort module has not been tested, need to also write tests for BHoMObject and check that existing unit tests still pass.
…ps with BHoM in grasshopper/excel (mainly testing with utci plot commands)
… the LBTBHoMJSONDecoder
…ulation/external comfort commands
…nvironment name to find the path to run_wrapped in case the environment is in an unexpected location
jamesramsden-bh
self-requested a review
September 15, 2026 15:35
Tom-Kingstone
left a comment
Tom-Kingstone
left a comment
Contributor
There was a problem hiding this comment.
This is now passing all tests @jamesramsden-bh
jamesramsden-bh
approved these changes
Sep 23, 2026
jamesramsden-bh
left a comment
jamesramsden-bh
left a comment
Contributor
There was a problem hiding this comment.
Approved as per Physics 9.3 testing plan
|
@BHoMBot just to let you know, I have provided a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LadybugTools_Toolkit
Feature
BHoMObjectimplementation from python_toolkit to simplify c#/python interop for all bhom/wrapped methods and adapter execute commands.Compliance
Bug