fix(wall): GRID_COLS 12 -> 6 (the change that missed PR #3) - #4
Merged
Merged
Conversation
The GRID_COLS reduction was supposed to ship in PR #3 but my amend was pushed after PR #3 had already been merged - so the merged commit only contained the colgroup fix, not the column-count reduction. Live org page still showed 12 columns and a horizontal scrollbar. Total table width: 6 x 55 = 330px (down from 12 x 55 = 660px). Fits viewports down to ~360px (most narrow mobile widths). Wall is now 26 rows tall for 151 contributors. Row count was previously confirmed acceptable. Tests: - Padding cells expected: 4 (was 10) for 2-cell first row - Two-rows test uses 8 items (was 14) since 12 cols fit more per row - colgroup test expects 6 <col> entries (was 12) - 36/36 passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this PR exists
The GRID_COLS reduction was meant to ship in PR #3, but my amend that included it was pushed AFTER PR #3 had already been merged. The merged commit on `main` (`cdf6bd0`) only contained the colgroup fix, not the column-count reduction. Result: live org page still shows 12 columns with horizontal scrollbar.
This PR delivers the change as originally intended.
What changes
Wall becomes 26 rows tall (was 13) for 151 contributors. You already confirmed row count is acceptable.
Tests