Participationtypes#1703
Merged
Merged
Conversation
bakobagassas
approved these changes
May 3, 2026
Contributor
bakobagassas
left a comment
There was a problem hiding this comment.
The code and the UI all look good to me! I am just still wondering about the Labor & Volunteer tag, as you cannot get paid for something you are volunteering for, but I guess that would be another issue. Good Job!
RueHaile
reviewed
May 4, 2026
Contributor
RueHaile
left a comment
There was a problem hiding this comment.
I see that we are using alias here which makes sense but it makes it merely a virtual column what do you think about making it a database column? As it seems like a good plus. It could be a new pr idea.
All looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Description
Fixes #1631
Changes
Refactored the getParticipatedEventsForUser(user) function to also add the column of event participant type and if the event is for volunteer the student participation type is volunteer, if the event is labor only it is labor else it is attendees.
Added test case for getParticipatedEventsForUser function and checked the returned participation types.
Rationale: This implementation can only be accurate if the eventParticiapant table has a new column which is participant type and we would need a script to populate it. However, this implementation is to give an approximation before the full implementation.
Testing
git checkout participationTypegit pull&git fetch origindatabase/reset_database.sh testtests/run_tests.shdatabase/reset_database.sh from-backupflask run