Skip to content

solved the responsiveness issue#1702

Open
bakobagassas wants to merge 9 commits into
developmentfrom
infoCheckbox
Open

solved the responsiveness issue#1702
bakobagassas wants to merge 9 commits into
developmentfrom
infoCheckbox

Conversation

@bakobagassas
Copy link
Copy Markdown
Contributor

@bakobagassas bakobagassas commented Apr 28, 2026

Issue Description

Fixes #1689

  • Upon going to a created event and clicking to the Volunteer Details tab, there are multiple checkboxes that are meant to toggle the information that is visible on the page. These checkboxes are not toggling the information shown as they should. When unchecked, information still appears anyway.

Changes

  • arranged the mispeled ID and made getcheckboxes hid and show table cells not just cards
  • rearranged the order of the checkboxes to match the table columns

Testing

The checkboxes are now working!
image

@bakobagassas bakobagassas self-assigned this Apr 28, 2026
@MImran2002
Copy link
Copy Markdown
Contributor

UI testing fixes:
This is the first page we don't uncheck anything:
image

This is the second page and even without and box uncheck we can see the insurance column being hidden but taking up space.
image

This is the second page and if we unchecked the second box we see the information is hidden but the columns spaces are still there:
image

If we unchecked more the second page move to the first page again and would break the view too:
image

Copy link
Copy Markdown
Contributor

@MImran2002 MImran2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working perfectly, the only fix left is the responsiveness of the table. I wanted to see if it is necessary and it the development it is responsive:
image

But in the branch it is not working. This is the bug: in the first populated table when you first get there the responsiveness is good then you deselect the checkmarks and the table loses the columns and retain the width but when you add the checkmark again the responsiveness break. I think the columns are added again on top of the total width breaking the responsiveness aside. This could exist in the development too because in the development the checkmark itself is breaking so this responsiveness bug was hidden. Aside from this the code working:
image

potential solution could be to wrapped the table with a fixed responsive div and allow the table to expand and contract by 100%, this could be a solution there can be more solutions too.

@bakobagassas
Copy link
Copy Markdown
Contributor Author

For some reason I am not able to reproduce this bug on my branch. Did you pull the changes?

MImran2002 added 3 commits May 9, 2026 15:10
…table remove the columsn but when the checkmark are ticekd back the action broke the table's responsivness. This isn't a bug created by Sara but it was responsive bug that already exist but was not discover because the checkmark was broken. The fixed now is to have a wrapper around the table to maintain its responsivness while allowing the table to be responsive wihtin the wrapper.
Copy link
Copy Markdown
Contributor

@MImran2002 MImran2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the table's responsiveness breaks when the checkmarks are toggle the table remove the columns but when the checkmark are ticked back the action broke the table's responsiveness. This isn't a bug created by Sara but it was responsive bug that already exist but was not discover because the checkmark was broken. The fixed now is to have a wrapper around the table to maintain its responsiveness while allowing the table to be responsive within the wrapper.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 9, 2026

View Code Coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Event Included Information Checkbox Toggles Do Not Work

2 participants