[refactor] 웹 동아리 사이드바 공통화 및 상세 UI 정리#321
Hidden character warning
Conversation
|
Warning Review limit reached
More reviews will be available in 56 minutes and 5 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (3)
Walkthrough웹 동아리 목록(UniversityClubList)과 상세 페이지(ClubDetail)에서 중복되던 대학 정보/최근 본 동아리 사이드바를 UniversityClubSidebar 공통 컴포넌트로 분리하여 두 페이지에 적용합니다. 동시에 ClubDetail의 동아리 소개 영역을 정적 섹션에서 INTRODUCE_MEDIA_ITEMS 매핑 기반 동적 카드 렌더링으로 개선하고, UniversityClubList의 데이터 추출 로직을 Possibly related PRs
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ff1451
force-pushed
the
320-refactor-웹-동아리-사이드바-공통화-및-상세-ui-정리
branch
from
85c7a60 to
1778418
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (2)
apps/web/src/pages/ClubDetail/index.tsx (1)
35-35: ⚡ Quick win인라인 HEX 대신 디자인 토큰 클래스 사용이 필요합니다.
Line 35의
bg-[#F8FAFC]는 토큰 기반 클래스(또는@konect/design-tokensCSS export)로 교체해주세요.As per coding guidelines, "Use CSS export from
@konect/design-tokensfor design tokens, prioritized over inline values".🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/web/src/pages/ClubDetail/index.tsx` at line 35, Replace the inline HEX background class used in the section element's className in ClubDetail (the `bg-[`#F8FAFC`]` token in the <section> element) with the corresponding design-token class from the CSS export of `@konect/design-tokens`; import/apply the exported token class (instead of the hex utility) so the section uses the canonical token name from `@konect/design-tokens` rather than the hard-coded `#F8FAFC`.apps/web/src/components/UniversityClubSidebar/index.tsx (1)
21-22: ⚡ Quick win시맨틱 타이포 유틸리티로 통일해주세요.
Line 21, Line 22, Line 28의
text-[24px],text-[20px]는text-h*/text-body*계열로 치환하는 게 컨벤션에 맞습니다.As per coding guidelines, "Prioritize semantic typography utilities (e.g.,
text-h1,text-body1) over generic utilities".Also applies to: 28-28
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/web/src/components/UniversityClubSidebar/index.tsx` around lines 21 - 22, Replace the literal pixel typography classes in the UniversityClubSidebar component with semantic typography utilities: change the h1 using universityLabel from "text-[24px]" to the semantic header class (e.g., "text-h4") and change the p showing clubCount from "text-[20px]" to the semantic body class (e.g., "text-body1"); also find the other occurrence mentioned (the other "text-[20px]" on the same component) and replace it with the appropriate "text-h*" or "text-body*" semantic class to match your design system. Ensure you update the className strings on the h1, p, and the other element (referencing universityLabel and clubCount usage) to use the semantic utilities consistently.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@apps/web/src/components/UniversityClubSidebar/index.tsx`:
- Around line 21-22: Replace the literal pixel typography classes in the
UniversityClubSidebar component with semantic typography utilities: change the
h1 using universityLabel from "text-[24px]" to the semantic header class (e.g.,
"text-h4") and change the p showing clubCount from "text-[20px]" to the semantic
body class (e.g., "text-body1"); also find the other occurrence mentioned (the
other "text-[20px]" on the same component) and replace it with the appropriate
"text-h*" or "text-body*" semantic class to match your design system. Ensure you
update the className strings on the h1, p, and the other element (referencing
universityLabel and clubCount usage) to use the semantic utilities consistently.
In `@apps/web/src/pages/ClubDetail/index.tsx`:
- Line 35: Replace the inline HEX background class used in the section element's
className in ClubDetail (the `bg-[`#F8FAFC`]` token in the <section> element) with
the corresponding design-token class from the CSS export of
`@konect/design-tokens`; import/apply the exported token class (instead of the hex
utility) so the section uses the canonical token name from `@konect/design-tokens`
rather than the hard-coded `#F8FAFC`.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 2e972fd8-9dd7-4692-ace3-022eaf04299a
⛔ Files ignored due to path filters (2)
apps/web/src/assets/svg/add-mov-icon.svgis excluded by!**/*.svg,!apps/*/src/assets/**and included by**apps/web/src/assets/svg/add-photo-icon.svgis excluded by!**/*.svg,!apps/*/src/assets/**and included by**
📒 Files selected for processing (3)
apps/web/src/components/UniversityClubSidebar/index.tsxapps/web/src/pages/ClubDetail/index.tsxapps/web/src/pages/UniversityClubList/index.tsx
1 participant
✨ 요약
😎 해결한 이슈
Summary by CodeRabbit
릴리스 노트
새로운 기능
개선 사항