[feat] 디자인 변경에 따른 웹 홈 UI 크기 조정#315
Hidden character warning
Conversation
|
Warning Review limit reached
More reviews will be available in 53 minutes and 30 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Walkthrough디자인 변경 사항에 맞춰 웹 홈 화면의 UI 크기와 간격을 조정하는 PR입니다. 헤더의 로고와 등록 버튼, 홈 페이지의 히어로 섹션, 최근 본 동아리/전체 대학 섹션, 그리고 카드 컴포넌트들의 Tailwind CSS 클래스를 일괄 수정하여 반응형 사이즈를 정리합니다. 구조적 변경은 제한적이며(지역 선택 버튼의 span 추가 제외) 대부분 기존 마크업의 클래스 교체 작업입니다. Possibly related PRs
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
apps/web/src/layout/Header/index.tsx (1)
7-7: ⚡ Quick winSPA 내비게이션은
<a>대신Link를 사용해주세요.
href="/"는 전체 페이지 리로드를 유발합니다. React Router 기반 라우팅이면Link to="/"로 바꾸는 게 UX/성능에 안전합니다.제안 코드
+import { Link } from 'react-router-dom'; import Logo from '`@/assets/image/Logo.png`'; function Header() { return ( <header className="border-text-100 border-b bg-white"> <div className="mx-auto flex h-15 w-full max-w-279 items-center justify-between px-2 lg:h-21 lg:px-10"> - <a className="flex h-full items-center" href="/" aria-label="Konect 홈"> + <Link className="flex h-full items-center" to="/" aria-label="Konect 홈"> <img className="aspect-11/8 h-10 object-center mix-blend-multiply sm:h-10" src={Logo} alt="로고" /> <span className="text-primary-500 [font-family:var(--font-cal-sans)] text-[28px] leading-9 font-normal sm:text-[32px] sm:leading-10"> Konect </span> - </a> + </Link>As per coding guidelines,
**/*.{tsx,ts}files should follow React/TypeScript conventions, and route transitions in SPA should be handled with router primitives.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/web/src/layout/Header/index.tsx` at line 7, The anchor tag <a className="flex h-full items-center" href="/" aria-label="Konect 홈"> should be replaced with the router Link component to avoid full page reloads in the SPA: update the Header component to import Link from "react-router-dom", change the element to <Link> keeping className and aria-label, and replace href="/" with to="/"; ensure any TypeScript types or props in the surrounding Header component remain compatible with Link.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/web/src/pages/Home/index.tsx`:
- Line 137: The Tailwind class string on the Home component contains an invalid
standalone variant token ("xl:") in the JSX element with className that
currently reads "xl: mt-7 grid ..."; update that className to use a valid
utility/variant syntax (e.g., change "xl: mt-7" to "xl:mt-7" or remove the stray
"xl:"), ensuring the element’s className string (the div with className
containing "mt-7 grid grid-cols-1 ...") uses correct Tailwind v4 conventions.
---
Nitpick comments:
In `@apps/web/src/layout/Header/index.tsx`:
- Line 7: The anchor tag <a className="flex h-full items-center" href="/"
aria-label="Konect 홈"> should be replaced with the router Link component to
avoid full page reloads in the SPA: update the Header component to import Link
from "react-router-dom", change the element to <Link> keeping className and
aria-label, and replace href="/" with to="/"; ensure any TypeScript types or
props in the surrounding Header component remain compatible with Link.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: f7659f80-3854-4e42-8cd3-c971ed17a5ad
📒 Files selected for processing (2)
apps/web/src/layout/Header/index.tsxapps/web/src/pages/Home/index.tsx
1 participant
✨ 요약
😎 해결한 이슈
Summary by CodeRabbit