test: make the DECLARE conflict tests pass without a Java backend - #697
Merged
Merged
Conversation
The two conflict tests resolved java.lang.String and java.lang.Integer through the real Java interop on :5008. CI has no backend, so neither type resolved, the check stayed silent by design, and both tests failed, which blocked the preview publish after #691. Validate them with createBBjTestServices and a preloaded unrelated pair (String, HashMap). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
📦 Test build ready —
|
StephanWald
deleted the
fix/variable-scoping-hermetic-declare-conflict
branch
September 24, 2026 06:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Publish Preview run for #691 (run 35957793016) failed in `verify`, and bump-version and both publishes were skipped.
Cause: two tests in `test/variable-scoping.test.ts` resolved `java.lang.String` and `java.lang.Integer` through the real Java interop on `localhost:5008`. Since #691, the conflicting-DECLARE check only reports a pair of classes when both resolve. An unresolved type is not treated as evidence of a conflict. CI has no backend, so the check stayed silent and both tests found no diagnostic. They passed locally only because BBjServices listens on :5008.
Fix: only the test changes, not the validator. The two tests now validate through `createBBjTestServices`. Its test double preloads `java.lang.String` and `java.util.HashMap`, an unrelated pair, and never opens a socket. The other 35 tests keep the real services.
Verified locally:
🤖 Generated with Claude Code