Add OpenFOAM implementation of rotating cylinders scenario#80
Conversation
berndflemisch
force-pushed
the
add-openfoam-rotating-cylinders
branch
from
0d06815 to
b024cf3
Compare
Follows the same pattern as the DuMuX implementation: extract rotating-cylinders.zip, iterate parameters_*.json, copy OpenFOAM template files per config, run Snakemake with cwd=output_dir. Snakefile now reads parameters.json and substitutes r0, r1, nr, ntheta, g, omega into the templates via sed. Remove unused cases/ dir. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This looks pretty ok by now. @Sarbani-Roy Can you please have a look? |
|
This looks good to me as well. @joergfunger can proceed with the necessary steps for the merge. I suggest we create a separate issue to implement a convergence test for the OpenFOAM example and to plot both the DuMuX and OpenFOAM results in the same figure. As I understand it, this is also one of the goals of the project. |
@Sarbani-Roy could you please approve the merge-request then i can merge |
|
The pipeline for the rotating-cylinders DuMux case is currently broken due to an internal GitLab server issue preventing it from pulling the container image from our GitLab Container Registry. This is unrelated to @berndflemisch's implementation and will resume working once the GitLab server is up. |
3 participants
Supersedes #13.