Extendablefem neumann bc & L2 error#77
Merged
Merged
Conversation
Collaborator
Author
|
It is interesting to note that all benchmarks should agree on the boundary condition as the overall error for the same grid is about 4-5 times larger with Neumann BC, although this does not impact the convergence order. |
joergfunger
requested changes
May 6, 2026
Member
There was a problem hiding this comment.
would it be possible to add the other metrics as discussed in #78? I was also not able to add local comments (not sure what the problem is), that's why here, where is the L2 error actually computed, from the changes I did not see that.
joergfunger
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the top and right boundary conditions to Neumann, matching the benchmark description.
As we decided to output the L2 error as a solution metric (if possible),
the already computed error gets output as well.