Skip to content

feat(skills): contribute CA containerization skills gated behind aksskillsEnabledPreview - #2314

Open
benjaminbob21 wants to merge 11 commits into
Azure:mainfrom
benjaminbob21:feat/ca-skills-preview
Open

feat(skills): contribute CA containerization skills gated behind aksskillsEnabledPreview#2314
benjaminbob21 wants to merge 11 commits into
Azure:mainfrom
benjaminbob21:feat/ca-skills-preview

Conversation

@benjaminbob21

Copy link
Copy Markdown

Bundle the five Containerization Assist skills (analyze-repo, generate-dockerfile, fix-dockerfile, generate-k8s-manifests, deploy-to-aks) from the containerization-assist-mcp package into dist/skills at build time and register them via contributes.chatSkills, each gated by a new aks.skillsEnabledPreview preview flag (default off). Coexists with the in-repo kickstart-* skills; the containerization-assist-mcp dependency is already present on this branch.

…skillsEnabledPreview

Bundle the five Containerization Assist skills (analyze-repo, generate-dockerfile, fix-dockerfile, generate-k8s-manifests, deploy-to-aks) from the containerization-assist-mcp package into dist/skills at build time and register them via contributes.chatSkills, each gated by a new aks.skillsEnabledPreview preview flag (default off). Coexists with the in-repo kickstart-* skills; the containerization-assist-mcp dependency is already present on this branch.
@benjaminbob21
benjaminbob21 marked this pull request as ready for review July 16, 2026 17:44
@benjaminbob21
benjaminbob21 force-pushed the feat/ca-skills-preview branch 2 times, most recently from b27b083 to 473f9f2 Compare July 16, 2026 18:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for contributing the Containerization Assist skill set to the extension by bundling skill prompt files into dist/skills at build time and registering them under contributes.chatSkills, gated behind a new preview setting (aks.skillsEnabledPreview, default off). It extends the existing Copilot agent/skill contributions without interfering with the in-repo kickstart-* skills.

Changes:

  • Add a webpack build step to copy containerization-assist-mcp skills into dist/skills (and clean that directory on builds).
  • Introduce aks.skillsEnabledPreview setting and conditionally contribute 5 new chat skills from ./dist/skills/**.
  • Pin VS Code integration tests to run against VS Code 1.128.1.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
webpack.config.js Cleans and copies Containerization Assist skill files into the webpack output (dist/skills).
src/tests/runTests.ts Pins the VS Code version used by @vscode/test-electron integration tests.
package.json Adds the preview flag and registers the 5 new chat skills pointing at ./dist/skills/....

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread webpack.config.js

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

Comment thread webpack.config.js
Comment thread src/tests/runTests.ts Outdated
Comment thread package.json Outdated
Comment thread package.json Outdated
Comment thread package.json Outdated
Comment thread package.json
Comment thread package.json Outdated
@Tatsinnit

Copy link
Copy Markdown
Member

Hi @benjaminbob21, great work on the build setup and script extraction!

I'd like to suggest consolidating aks.kickstartEnabledPreview and aks.skillsEnabledPreview into a single flag in this PR, rather than waiting for a future refactor. Here's the reasoning:

Why now is better than later:

  • Both flags control access to the same conceptual feature: AKS agent/skill capabilities
  • You're already planning to consolidate them when CA skills replace kickstart skills
  • Consolidating now avoids a multi-phase refactor + deprecation cycle later
  • Users see one clear setting for "enable AKS preview skills"
  • Implementation: Keep aks.skillsEnabledPreview (or rename to aks.agentSkillsEnabledPreview for clarity), and update all kickstart skill when clauses to use it. ~15 lines of change in this PR.

Benefits:

  • No future flag rename/migration needed
  • Clearer semantics in settings UI
  • Single source of truth for preview features
  • Reduced maintenance burden when skills eventually merge

Would you be open to this in this PR? Happy to discuss if you see constraints I'm missing!

Also, let's also document if the previous flag is not documented properly. Thank you!

@bosesuneha

Copy link
Copy Markdown
Member

@benjaminbob21 I feel we can have the skills available by default without having them gated behind a flag. As @Tatsinnit pointed out it might get confusing to maintain so many similar flags. For better clarity, could you please add the motivation behind adding the skills in the extension?

@benjaminbob21

benjaminbob21 commented Jul 28, 2026

Copy link
Copy Markdown
Author

Hi @benjaminbob21, great work on the build setup and script extraction!

I'd like to suggest consolidating aks.kickstartEnabledPreview and aks.skillsEnabledPreview into a single flag in this PR, rather than waiting for a future refactor. Here's the reasoning:

Why now is better than later:

  • Both flags control access to the same conceptual feature: AKS agent/skill capabilities
  • You're already planning to consolidate them when CA skills replace kickstart skills
  • Consolidating now avoids a multi-phase refactor + deprecation cycle later
  • Users see one clear setting for "enable AKS preview skills"
  • Implementation: Keep aks.skillsEnabledPreview (or rename to aks.agentSkillsEnabledPreview for clarity), and update all kickstart skill when clauses to use it. ~15 lines of change in this PR.

Benefits:

  • No future flag rename/migration needed
  • Clearer semantics in settings UI
  • Single source of truth for preview features
  • Reduced maintenance burden when skills eventually merge

Would you be open to this in this PR? Happy to discuss if you see constraints I'm missing!

Also, let's also document if the previous flag is not documented properly. Thank you!

Thanks Tats! Sounds great to me. Happy to make the change. Just some quick things to highlight, the current kickstart flag not only enables the skills but also the kickstart agent itself so might not totally be accurate to have it named aks.skillsEnabledPreview or anything with a skills naming. I expect that the kickstart agent shouldn't be enabled without the kickstart skills so they can't be under separate flags. I'm leaning towards Suneha's idea to just have the skills available by default without having them gated behind a flag.
Another option will be to just have the 5 skills gated behind the kickstartEnabledPreview flag or maybe some name more nuanced than that to accomodate all. Glad to have some more of your thoughts on this via teams chat for better conversations and get @bosesuneha opinions on this too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants