feat(skills): contribute CA containerization skills gated behind aksskillsEnabledPreview - #2314
feat(skills): contribute CA containerization skills gated behind aksskillsEnabledPreview#2314benjaminbob21 wants to merge 11 commits into
Conversation
…skillsEnabledPreview Bundle the five Containerization Assist skills (analyze-repo, generate-dockerfile, fix-dockerfile, generate-k8s-manifests, deploy-to-aks) from the containerization-assist-mcp package into dist/skills at build time and register them via contributes.chatSkills, each gated by a new aks.skillsEnabledPreview preview flag (default off). Coexists with the in-repo kickstart-* skills; the containerization-assist-mcp dependency is already present on this branch.
b27b083 to
473f9f2
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds support for contributing the Containerization Assist skill set to the extension by bundling skill prompt files into dist/skills at build time and registering them under contributes.chatSkills, gated behind a new preview setting (aks.skillsEnabledPreview, default off). It extends the existing Copilot agent/skill contributions without interfering with the in-repo kickstart-* skills.
Changes:
- Add a webpack build step to copy
containerization-assist-mcpskills intodist/skills(and clean that directory on builds). - Introduce
aks.skillsEnabledPreviewsetting and conditionally contribute 5 new chat skills from./dist/skills/**. - Pin VS Code integration tests to run against VS Code
1.128.1.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
webpack.config.js |
Cleans and copies Containerization Assist skill files into the webpack output (dist/skills). |
src/tests/runTests.ts |
Pins the VS Code version used by @vscode/test-electron integration tests. |
package.json |
Adds the preview flag and registers the 5 new chat skills pointing at ./dist/skills/.... |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hi @benjaminbob21, great work on the build setup and script extraction! I'd like to suggest consolidating Why now is better than later:
Benefits:
Would you be open to this in this PR? Happy to discuss if you see constraints I'm missing! Also, let's also document if the previous flag is not documented properly. Thank you! |
|
@benjaminbob21 I feel we can have the skills available by default without having them gated behind a flag. As @Tatsinnit pointed out it might get confusing to maintain so many similar flags. For better clarity, could you please add the motivation behind adding the skills in the extension? |
Thanks Tats! Sounds great to me. Happy to make the change. Just some quick things to highlight, the current kickstart flag not only enables the skills but also the kickstart agent itself so might not totally be accurate to have it named |
Bundle the five Containerization Assist skills (analyze-repo, generate-dockerfile, fix-dockerfile, generate-k8s-manifests, deploy-to-aks) from the containerization-assist-mcp package into dist/skills at build time and register them via contributes.chatSkills, each gated by a new aks.skillsEnabledPreview preview flag (default off). Coexists with the in-repo kickstart-* skills; the containerization-assist-mcp dependency is already present on this branch.