fix(net): allow coexisting CNI configurations - #590
Merged
Patrick W. Healy (phealy) merged 1 commit intoAug 8, 2026
Conversation
Remove the fatal bootstrap check that required unbounded-net to be the only configured CNI plugin. Continue writing the unbounded-net configuration when other CNI files are present. Detect supported CNI configuration files that sort before the unbounded-net file and log a warning explaining that unbounded-net is not the active CNI plugin. Files that sort later are allowed without a warning. Update bootstrap tests to cover higher- and lower-priority CNI configurations, supported file extensions, and successful node initialization alongside an existing CNI. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: bbf9702f-158a-4c6c-b1c2-5120cd2ab78a
Patrick W. Healy (phealy)
enabled auto-merge
August 8, 2026 13:15
Jason Wilder (jwilder)
approved these changes
Aug 8, 2026
Patrick W. Healy (phealy)
deleted the
pahealy/net-remove-single-cni-check
branch
August 8, 2026 14:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.conf,.conflist, and.jsonfiles that sort before the unbounded-net config and warn that unbounded-net is not the active CNI pluginValidation
go test ./cmd/unbounded-net-nodegolangci-lint run -c .golangci.yaml ./cmd/unbounded-net-node