Skip to content

Enable containerd device ownership from security context #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Patrick W. Healy (phealy) wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Enable containerd device ownership from security context #548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e543f19
agent: preserve mapped device ownership
phealy Jul 27, 2026
d2eb365
Fix containerd device ownership config section
phealy Aug 6, 2026
d8fc5a8
Merge branch 'main' into feature/containerd-device-ownership
bcho Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/agent/phases/nodestart/assets/containerd.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ oom_score = 0
version = 2

[plugins."io.containerd.grpc.v1.cri"]
device_ownership_from_security_context = true
sandbox_image = "{{.SandboxImage}}"

[plugins."io.containerd.grpc.v1.cri".containerd]
Expand Down
31 changes: 31 additions & 0 deletions pkg/agent/phases/nodestart/cri_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
"context"
"os"
"path/filepath"
"strings"
"testing"

"github.com/stretchr/testify/require"
Expand Down Expand Up @@ -35,6 +36,36 @@ func TestConfigureContainerdWritesGantryHostsConfig(t *testing.T) {
require.Equal(t, os.FileMode(0o644), info.Mode().Perm())
}

func TestConfigureContainerdEnablesDeviceOwnershipFromSecurityContext(t *testing.T) {
t.Parallel()

machineDir := t.TempDir()
goalState := &goalstates.NodeStart{
MachineDir: machineDir,
Containerd: goalstates.ResolveContainerd(""),
}

require.NoError(t, ConfigureContainerd(goalState).Do(context.Background()))

path := filepath.Join(machineDir, goalstates.ContainerdConfigPath)
data, err := os.ReadFile(path)
require.NoError(t, err)

config := string(data)

const sectionHeader = `[plugins."io.containerd.grpc.v1.cri"]`

sectionStart := strings.Index(config, sectionHeader)
require.NotEqual(t, -1, sectionStart)

section := config[sectionStart+len(sectionHeader):]
if sectionEnd := strings.Index(section, "\n["); sectionEnd >= 0 {
section = section[:sectionEnd]
}

require.Contains(t, section, "device_ownership_from_security_context = true")
}

func TestConfigureContainerdUpdatesManagedGantryHostsConfig(t *testing.T) {
t.Parallel()

Expand Down
Loading