Split createRequestHandler into smaller functions - #5187
Merged
Joel Hendrix (jhendrixMSFT) merged 1 commit intoAug 7, 2026
Conversation
Copilot started reviewing on behalf of
Joel Hendrix (jhendrixMSFT)
August 7, 2026 21:28
View session
microsoft-github-policy-service
Bot
added
the
emitter:go
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors Go request-handler generation by extracting inline lambdas into documented helper functions.
Changes:
- Extracts parameter, header, path, query, and body helpers.
- Adds an internal Chronus change entry.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
packages/typespec-go/src/codegen/core/request-handler.ts |
Refactors request-generation logic. |
.chronus/changes/main-2026-7-7-14-22-54.md |
Records the internal refactor. |
Contributor
|
All changed packages have been documented.
Show changes
|
Contributor
📦 Package size report✅ No notable package size changes compared to the base branch. 13 package(s) with no notable change
Packed = gzipped |
commit: |
Contributor
|
You can try these changes here
|
Joel Hendrix (jhendrixMSFT)
force-pushed
the
go-request-handler
branch
from
August 7, 2026 21:47
d6fb5aa to
4c2cb5d
Compare
Moved most inline lambdas to discrete functions and added doc comments. The small ones used in one place were replaced with inline code.
Joel Hendrix (jhendrixMSFT)
force-pushed
the
go-request-handler
branch
from
August 7, 2026 22:05
4c2cb5d to
932714d
Compare
Joel Hendrix (jhendrixMSFT)
marked this pull request as ready for review
August 7, 2026 22:05
Joel Hendrix (jhendrixMSFT)
enabled auto-merge
August 7, 2026 22:05
Jeff Fisher (xirzec)
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved most inline lambdas to discrete functions and added doc comments. The small ones used in one place were replaced with inline code.
No functional changes.