Repository navigation
fix(queue): validate CPU topology flavor compatibility - #537
Open
Kevin Cho (chokevin) wants to merge 3 commits into
Open
Kevin Cho (chokevin) wants to merge 3 commits into
Kevin Cho (chokevin) wants to merge 3 commits into
Conversation
Pengfei Ni (feiskyer)
requested changes
Nov 6, 2026
Kevin Cho (chokevin)
requested review from
Pengfei Ni (feiskyer)
and removed request for
Pengfei Ni (feiskyer)
November 6, 2026 17:41
Kevin Cho (chokevin)
requested review from
Pengfei Ni (feiskyer)
and removed request for
Pengfei Ni (feiskyer)
November 12, 2026 01:08
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CPU-only workloads that requested topology could pass connected queue preflight even when every eligible CPU flavor lacked topology support. The CLI now detects CPU requests in rendered workloads and rejects incompatible queue selections before submission, while accepting topology-capable CPU flavors.
getpermission needed to inspect ResourceFlavor topology capability in both Helm and Kustomize installs.Related issue
N/A
Validation
Evidence
The updated 16-second recording shows the focused ResourceFlavor read grant, its least-privilege boundary, and the new Forbidden/actionable-guidance regression. Detailed command results remain in the validation section above.
cpu-topology-forbidden-guidance.mp4
Compatibility and operational impact
CLI connected preflight is intentionally stricter for CPU-only workloads that set
policy.topology: queues whose eligible CPU flavors do not support topology-aware scheduling are rejected before submission. The shipped workspace researcher RBAC now permits cluster-scoped ResourceFlavorgetrequests, but still does not grant list, watch, or mutation access. Public APIs, CRDs, configuration formats, images, and dependencies are unchanged. Documentation is not changed because this aligns shipped authorization with an existing preflight read rather than introducing a new user-facing command, flag, or configuration contract.Checklist