Repository navigation
fix(install): correct Portal opt-out and gate chart image availability - #531
Closed
Kevin Cho (chokevin) wants to merge 2 commits into
Closed
Kevin Cho (chokevin) wants to merge 2 commits into
Kevin Cho (chokevin) wants to merge 2 commits into
Conversation
Contributor
Author
|
16-second evidence: the exact CLI change, actual umbrella-chart renders with the old and corrected settings, the all-candidate-before-push gate, and a controlled missing-image failure through the real verification script. Offline fixture only; no release publication or cluster execution. install-release-evidence.mp4 |
Contributor
Author
|
Closing to consolidate release publication work around #532. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The install help's disable-Portal example used a value the umbrella chart ignores, while chart publication could succeed before its required runtime images were available. The example now uses the subchart key, and publication verifies all candidate archives' rendered images before pushing any chart.
taugrid-core.portal.enabled=falsein help and document the setting. The plan explicitly lists defaults before Helm overrides; readiness checks enabled components and skips disabled ones.verify-imagescommand and focused publisher regressions.Review the all-candidate verification before the first push in
scripts/ci/publish-helm-charts.sh, then the executable help regression incli/internal/cli/cluster_install_test.go.Related issue
Closes #528.
Relates to #527. This prevents recurrence but does not publish the missing 0.4.8 Portal image or resolve the current installation failure. Recovery remains a separate authorized release operation.
Validation
Passed locally on macOS with Helm 4.2.0:
The new CLI regression failed on the old example before the fix. Actual umbrella renders retained one Portal image reference with
portal.enabled=falseand zero withtaugrid-core.portal.enabled=false. Read-only verification of the released 0.4.8 archive rejected the missing Portal image.No cluster installation, image publication or privileged chart push was performed. Live release recovery is not claimed.
Compatibility and operational impact
No public API, CRD, chart version, image tag or component-default changes. The plan describes chart defaults rather than claiming they are resolved overrides.
Chart publication now requires Helm, yq and Docker Buildx plus read access to required consumer image registries. The pipeline checks these tools before packaging. Any unavailable required image blocks all candidate chart pushes; restore the image or registry access rather than bypassing the gate. Disabled optional components and CRD schema examples are not treated as running images. Existing immutable chart versions remain skipped.
Checklist
AI assistance: GitHub Copilot implemented the changes, ran the listed checks and drafted this description.