{ARO} Migrate validator to aaz-based implementation - #34119
Open
William (william051200) wants to merge 1 commit into
Open
William (william051200) wants to merge 1 commit into
William (william051200) wants to merge 1 commit into
Conversation
|
Hi William (@william051200), |
Copilot started reviewing on behalf of
William (william051200)
September 23, 2026 02:53
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Add coverage for translating AAZ Show failures into InvalidArgumentValueError.
Review effort: Lite
Findings: None
What changed in this PR
Migrates ARO disk encryption set validation from the Compute SDK to the generated AAZ command.
Changes:
- Replaces SDK lookup with AAZ-based lookup.
- Updates validator unit tests for AAZ invocation and arguments.
| File | Summary |
|---|---|
src/azure-cli/azure/cli/command_modules/aro/tests/latest/unit/test_validators.py |
Updates tests for the AAZ implementation. |
src/azure-cli/azure/cli/command_modules/aro/_validators.py |
Uses the AAZ disk encryption set Show command. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
|
ARO |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ️✔️ All clear
Related command
Description
Migration from mgmt.compute to aaz-based
Testing Guide
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.