{ACS} Migrate _get_vm_sku_details function to aaz-based implementation and removed unused SDK function - #34117
Open
William (william051200) wants to merge 3 commits into
Open
William (william051200) wants to merge 3 commits into
William (william051200) wants to merge 3 commits into
Conversation
William (william051200)
requested review from
a team and
FumingZhang
as code owners
September 23, 2026 00:57
|
Hi William (@william051200), |
Copilot started reviewing on behalf of
William (william051200)
September 23, 2026 00:58
View session
microsoft-github-policy-service
Bot
requested review from
elvazhu521,
Julie Zhu (yanzhudd) and
Yong Zhang (yonzhan)
September 23, 2026 00:58
microsoft-github-policy-service
Bot
added
Auto-Assign
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Add focused mocked unit coverage for VM SKU filtering and capability caching.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
What changed in this PR
Migrates ACS VM SKU retrieval from the Compute SDK to an AAZ-based implementation and removes unused helpers.
Changes:
- Uses AAZ dictionary responses for SKU and capability handling.
- Removes the VM-size completer and Compute client factory.
- Requires focused mocked tests for SKU filtering, pagination, and capability caching.
| File | Summary |
|---|---|
src/azure-cli/azure/cli/command_modules/acs/azurecontainerstorage/_helpers.py |
Migrates VM SKU retrieval and cache processing to AAZ. |
src/azure-cli/azure/cli/command_modules/acs/_completers.py |
Removes the unused VM-size completer. |
src/azure-cli/azure/cli/command_modules/acs/_client_factory.py |
Removes the unused Compute client factory. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+655
to
+659
| from azure.cli.command_modules.vm.aaz.latest.vm import ListSkus | ||
| result = ListSkus(cli_ctx=cli_ctx)(command_args={}) | ||
| result = [x for x in result if x['resourceType'].lower() == 'virtualmachines'] | ||
| if location: | ||
| result = [r for r in result if _is_vm_in_required_location(location, r.locations)] | ||
| result = [r for r in result if _is_vm_in_required_location(location, r['locations'])] |
Collaborator
|
ACS |
Teresa Ritorto (teresaritorto)
requested review from
JaysonTaiMicrosoft and
NoriZC
September 23, 2026 03:50
Teresa Ritorto (teresaritorto)
previously approved these changes
Sep 23, 2026
FumingZhang
previously approved these changes
Sep 23, 2026
William (william051200)
dismissed stale reviews from FumingZhang and Teresa Ritorto (teresaritorto)
via
September 23, 2026 07:41
3339abe
Julie Zhu (yanzhudd)
approved these changes
Sep 23, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ️✔️ All clear
Related command
Description
Migration from mgmt.compute to aaz-based
Testing Guide
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.