{CI} Preserve squad mentions during service contact sync - #34087
Open
ZelinWang (wangzelin007) wants to merge 1 commit into
Open
ZelinWang (wangzelin007) wants to merge 1 commit into
ZelinWang (wangzelin007) wants to merge 1 commit into
Conversation
Keep existing Azure/act-...-squad mentionees when rebuilding service routing from the contact wiki. Add offline regression coverage for regular contact updates, exact team matching, and idempotent synchronization. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ae380b25-034e-4550-9636-fa1443bc8205
microsoft-github-policy-service
Bot
requested review from
Qi Pan (Pan-Qi),
Yu Chen (jsntcy) and
Yong Zhang (yonzhan)
September 16, 2026 00:26
Copilot started reviewing on behalf of
ZelinWang (wangzelin007)
September 16, 2026 00:26
View session
microsoft-github-policy-service
Bot
added
Reservations
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues were identified.
Pull request overview
Updates the internal service-contact synchronization pipeline to preserve squad mentions while continuing wiki-driven contact and service updates.
Changes:
- Preserve matching squad mentions without duplicates.
- Add offline regression coverage for synchronization behavior and idempotency.
File summaries
| File | Description |
|---|---|
tools/Github/tests/test_service_contacts.py |
Adds synchronization regression tests. |
tools/Github/ParseServiceContactsList.ps1 |
Preserves matching squad mentions during synchronization. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
|
CI |
Yu Chen (jsntcy)
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ️✔️ All clear
Related command
N/A - internal service-contact synchronization pipeline only.
Description
The service contact wiki does not contain the squad teams maintained by squad mapping. Rebuilding the triage rules from that wiki currently removes those teams and produces recurring removal PRs.
^Azure/act-[a-z0-9-]+-squad$on the corresponding service label.Azure/...teams are not exempted.Testing guide
Requires Python with pytest and PowerShell 7 (
pwsh) on PATH.The 20 targeted tests pass. An offline comparison of the checked-in policy confirms that omitting squads from the wiki leaves all 260 service rules unchanged and retains all 162 squad mentions.
No live wiki access, pipeline execution, or generated policy edits are needed for this fix.
History Notes
Internal CI automation only; no customer-facing command behavior changes or history entry.
Related PRs