Skip to content

{AKS} Stabilize remaining live-runner scenarios - #34037

Open
FumingZhang wants to merge 1 commit into
Azure:devfrom
FumingZhang:fix/aks-runner-post-merge-followups
Open

{AKS} Stabilize remaining live-runner scenarios#34037
FumingZhang wants to merge 1 commit into
Azure:devfrom
FumingZhang:fix/aks-runner-post-merge-followups

Conversation

@FumingZhang

@FumingZhang FumingZhang commented Sep 7, 2026

Copy link
Copy Markdown
Member

🤖 PR Validation — ❌ Action needed

Breaking Changes Tests
❌ 3 🔄 130/130
❌AzureCLI-BreakingChangeTest
❌eventhubs
rule cmd_name rule_message suggest_message
1012 - SubgroupRemove eventhubs cluster quota-configuration sub group eventhubs cluster quota-configuration removed please confirm sub group eventhubs cluster quota-configuration removed
1012 - SubgroupRemove eventhubs cluster upgrade-preference sub group eventhubs cluster upgrade-preference removed please confirm sub group eventhubs cluster upgrade-preference removed
1012 - SubgroupRemove eventhubs eventhub fabric-shortcut sub group eventhubs eventhub fabric-shortcut removed please confirm sub group eventhubs eventhub fabric-shortcut removed
1007 - ParaRemove eventhubs namespace update cmd eventhubs namespace update removed parameter confidential_compute_mode please add back parameter confidential_compute_mode for cmd eventhubs namespace update
⚠️ 1010 - ParaPropUpdate eventhubs eventhub update cmd eventhubs eventhub update update parameter min_compaction_lag_in_mins: updated property name from min_compaction_lag_in_mins to min_compaction_lag_time_in_minutes
❌network
rule cmd_name rule_message suggest_message
1007 - ParaRemove network route-table route create cmd network route-table route create removed parameter next_hop please add back parameter next_hop for cmd network route-table route create
1007 - ParaRemove network route-table route list cmd network route-table route list removed parameter pagination_limit please add back parameter pagination_limit for cmd network route-table route list
1007 - ParaRemove network route-table route list cmd network route-table route list removed parameter pagination_token please add back parameter pagination_token for cmd network route-table route list
1007 - ParaRemove network route-table route update cmd network route-table route update removed parameter next_hop please add back parameter next_hop for cmd network route-table route update
⚠️ 1010 - ParaPropUpdate network route-table route create cmd network route-table route create update parameter next_hop_type: updated property choices from ['Internet', 'None', 'VirtualAppliance', 'VirtualApplianceEcmp', 'VirtualNetworkGateway', 'VnetLocal'] to ['Internet', 'None', 'VirtualAppliance', 'VirtualNetworkGateway', 'VnetLocal']
⚠️ 1010 - ParaPropUpdate network route-table route update cmd network route-table route update update parameter next_hop_type: updated property choices from ['Internet', 'None', 'VirtualAppliance', 'VirtualApplianceEcmp', 'VirtualNetworkGateway', 'VnetLocal'] to ['Internet', 'None', 'VirtualAppliance', 'VirtualNetworkGateway', 'VnetLocal']
❌vm
rule cmd_name rule_message suggest_message
1007 - ParaRemove capacity reservation create cmd capacity reservation create removed parameter end please add back parameter end for cmd capacity reservation create
1007 - ParaRemove capacity reservation create cmd capacity reservation create removed parameter minimum_commitment_days please add back parameter minimum_commitment_days for cmd capacity reservation create
1007 - ParaRemove capacity reservation create cmd capacity reservation create removed parameter schedule_profile_start please add back parameter schedule_profile_start for cmd capacity reservation create
1007 - ParaRemove capacity reservation list cmd capacity reservation list removed parameter expand please add back parameter expand for cmd capacity reservation list

Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:

  • Breaking changes can only be merged during the designated breaking change window
  • A pre-announcement must be released at least one month in advance

For more details on how to introduce breaking changes, refer to the documentation: azure-cli/doc/how_to_introduce_breaking_changes.md

Related command

az aks create, az aks disable-addons, az aks nodepool add, az aks nodepool update

Description

Follow-up to #33886 for the remaining failures in AKS CLI runner run 7a0c88f6.

  • Poll persisted cluster state after monitoring and Container Network Logs updates instead of asserting asynchronous post-processing from the immediate response.
  • Pin a runner-allowlisted VM size for the kubenet-to-Azure-CNI-overlay migration scenario.
  • Skip Artifact Streaming scenarios only for the exact stable-API UnmarshalError that rejects artifactStreamingProfile; preview coverage remains in aks-preview.
  • Recover a retried Control Plane Metrics create from already exists only at the two explicitly opted-in call sites, while preserving negative duplicate-create coverage.
  • Add focused tests for polling, replay safety, exact error matching, and create-recovery scope.

This PR intentionally does not mask the remaining Automatic SKU SAMI validation failure, which requires an AKS RP fix.

Testing Guide

  • python -m pytest -q test_aks_provisioning_retry.py test_loadbalancer.py — 55 passed, 5 subtests passed.
  • python -m pytest --collect-only -q test_aks_commands.py — 283 tests collected.
  • python -m py_compile for changed Python files — passed.
  • git diff --check — passed.

History Notes

None. Test-only live-runner stabilization.


This checklist is used to make sure that common guidelines for a pull request are followed.

Poll persisted monitoring state, pin a supported migration VM size, narrowly skip preview-only Artifact Streaming on stable API, and add opt-in create-race recovery for Control Plane Metrics. Add focused retry and safety tests.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@yonzhan

Copy link
Copy Markdown
Collaborator

AKS

@FumingZhang
FumingZhang marked this pull request as ready for review September 7, 2026 05:18
@FumingZhang
FumingZhang requested a review from a team as a code owner September 7, 2026 05:18
Copilot AI lite review requested due to automatic review settings September 7, 2026 05:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are test-focused, narrowly scoped, and add targeted unit coverage for the new stabilization behaviors without widening skip/retry behavior broadly.

Pull request overview

This PR further stabilizes AKS live-runner scenarios in the acs command module test suite by making the tests resilient to asynchronous/settling behaviors observed in live runs, while keeping negative coverage for genuine failures.

Changes:

  • Add polling-based verification for specific cluster properties (aks show --query ...) instead of asserting immediately on the response from asynchronous operations.
  • Add narrowly-scoped recovery for aks create retries that end in an “already exists” conflict (only when explicitly opted-in by the test).
  • Skip Artifact Streaming scenarios only for the specific stable-API unmarshal failure that rejects artifactStreamingProfile, while leaving unrelated errors to fail normally.
File summaries
File Description
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_provisioning_retry.py Adds focused unit tests covering new polling behavior, retry “already exists” recovery, and exact Artifact Streaming error matching.
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py Implements new helper methods used by live scenarios (property polling, create-retry recovery wrapper, and exact Artifact Streaming skip handling) and updates affected live tests to use them.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@FumingZhang

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

act-observability-squad AKS az aks/acs/openshift Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants