{AKS} Stabilize remaining live-runner scenarios - #34037
Open
FumingZhang wants to merge 1 commit into
Open
Conversation
Poll persisted monitoring state, pin a supported migration VM size, narrowly skip preview-only Artifact Streaming on stable API, and add opt-in create-race recovery for Control Plane Metrics. Add focused retry and safety tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
microsoft-github-policy-service
Bot
requested review from
elvazhu521,
Julie Zhu (yanzhudd) and
Yong Zhang (yonzhan)
September 7, 2026 00:43
Collaborator
|
AKS |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are test-focused, narrowly scoped, and add targeted unit coverage for the new stabilization behaviors without widening skip/retry behavior broadly.
Pull request overview
This PR further stabilizes AKS live-runner scenarios in the acs command module test suite by making the tests resilient to asynchronous/settling behaviors observed in live runs, while keeping negative coverage for genuine failures.
Changes:
- Add polling-based verification for specific cluster properties (
aks show --query ...) instead of asserting immediately on the response from asynchronous operations. - Add narrowly-scoped recovery for
aks createretries that end in an “already exists” conflict (only when explicitly opted-in by the test). - Skip Artifact Streaming scenarios only for the specific stable-API unmarshal failure that rejects
artifactStreamingProfile, while leaving unrelated errors to fail normally.
File summaries
| File | Description |
|---|---|
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_provisioning_retry.py |
Adds focused unit tests covering new polling behavior, retry “already exists” recovery, and exact Artifact Streaming error matching. |
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py |
Implements new helper methods used by live scenarios (property polling, create-retry recovery wrapper, and exact Artifact Streaming skip handling) and updates affected live tests to use them. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ❌ Action needed
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
Related command
az aks create,az aks disable-addons,az aks nodepool add,az aks nodepool updateDescription
Follow-up to #33886 for the remaining failures in AKS CLI runner run
7a0c88f6.UnmarshalErrorthat rejectsartifactStreamingProfile; preview coverage remains inaks-preview.already existsonly at the two explicitly opted-in call sites, while preserving negative duplicate-create coverage.This PR intentionally does not mask the remaining Automatic SKU SAMI validation failure, which requires an AKS RP fix.
Testing Guide
python -m pytest -q test_aks_provisioning_retry.py test_loadbalancer.py— 55 passed, 5 subtests passed.python -m pytest --collect-only -q test_aks_commands.py— 283 tests collected.python -m py_compilefor changed Python files — passed.git diff --check— passed.History Notes
None. Test-only live-runner stabilization.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.