{Security} Set log file permissions to 600 on creation#33296
Draft
{Security} Set log file permissions to 600 on creation#33296
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
Bot
requested review from
jiasli,
jsntcy,
wangzelin007,
yonzhan and
zhoxing-ms
microsoft-github-policy-service
Bot
added
ARM
huiii99
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Fixes https://github.com/Azure/CLIPS/issues/21
Azure CLI debug log files may contain credentials and secrets. Currently, log files are created with default permissions (
0o644on Linux), which allows other users on the same system to read sensitive data.This PR introduces custom secure file handlers (
SecureFileHandlerandSecureRotatingFileHandler) that override_open()to atomically create log files with0o600(owner read/write only) permissions usingos.open().Testing Guide
Automated Tests
Manual Testing (WSL / Linux)
Manual Testing (Windows)
Test Results
Linux
0o644(-rw-r--r--)0o600(-rw-------)0o644(-rw-r--r--)0o600(-rw-------)0o600(-rw-------)Windows does not use POSIX file permissions. File access is managed by Windows ACLs. The secure handler works without errors on Windows — the
0o600mode is a no-op, which is expected and harmless.History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.