{Dataprotection} Fix AKS backup storage and vault compatibility - #10314
Draft
FumingZhang wants to merge 2 commits into
Draft
FumingZhang wants to merge 2 commits into
FumingZhang wants to merge 2 commits into
Conversation
|
Hi FumingZhang, |
microsoft-github-policy-service
Bot
requested a review
from Yong Zhang (yonzhan)
September 9, 2026 06:35
Yong Zhang (yonzhan)
requested review from
Ethan Yang (necusjz) and
Julie Zhu (yanzhudd)
September 9, 2026 06:52
Collaborator
|
Dataprotection |
Keep full service errors when redundancy fallback is exhausted, propagate local failures, and require successful provisioning before configuring new or reused backup vaults. Validate real AAZ create and polling contracts. Validation: 72 targeted tests and 32 subtests passed, plus syntax and style checks. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fix live-discovered cross-resource-group storage reuse and configure the extension using the actual storage account ID. Keep automatic AKS vault creation on the supported API for reversible soft delete without changing general vault cost-management commands. Both affected backup scenarios passed live with the final source before this commit. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
FumingZhang
force-pushed
the
fix/dataprotection-live-validation-20260909
branch
from
September 17, 2026 03:09
11a46f2 to
1975410
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ️✔️ All clear
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az dataprotection enable-backup trigger, as used byaz aks create/update --enable-backup.What / Why
Follow-up to #10309:
ResourceNotFound.2025-07-01create API to preserve their existing reversible soft-deleteOn/14-day behavior. The newly generated2026-06-01vault API rejects that setting withDppAlwaysOnSoftDeleteStateMandatory; silently enabling irreversible AlwaysOn would change existing behavior.Rebased after the intervening 1.13.0 release. The pending fix version is now 1.13.1, preserving 1.13.0's cost-management changes and the earlier Elastic SAN work.
Validation
September 17 live validation
test_aks_create_with_enable_backup: passed, 1231.08 seconds.test_aks_update_with_enable_backup: passed, 2200.26 seconds.Succeeded, soft deleteOn, and 14-day retention.Other validation
2026-06-01and serializes cost-management settings; the AKS operation alone uses the compatible API.These fixes do not claim to remove service restrictions, quota exhaustion, or provisioning failures in every runner subscription. Those errors remain visible.
Scope / History
1.13.0to1.13.1, with matching release notes.General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired) - targeted syntax/diff checks and regression tests passed; full style remains with CI.python scripts/ci/test_index.py -qlocally? (pip install azdevrequired) - index unchanged.For new extensions:
About Extension Publish
Publish version 1.13.1 after review. The index is managed by release automation.