[Compute] Add default subnet address prefixes when not specified by JaysonTaiMicrosoft · Pull Request #1412 · Azure/azclips

JaysonTaiMicrosoft · 2026-11-12T01:14:18Z

Related command

az vm create ...

Description

Resolves #1338 by adding default subnet / address prefixes on vnet creation. Will not override settings of existing vnets settings that are found.
Remove --network-interface-name not a parameter that was originally supported. see https://learn.microsoft.com/en-us/cli/azure/vm?view=azure-cli-latest#az-vm-create for reference

Testing Guide

History Notes

[Compute] Add default subnet address prefixes when not specified
[Compute] az vm create: Remove --network-interface-name param

The PR title starts with [Component Name] for customer-facing changes or {Component Name} for non-customer-facing changes, and does not end with trailing punctuation or spaces.
Customer-facing changes include a useful release note in the PR title or the History Notes section.
I added or updated tests for behavior changes.
I updated documentation when behavior, setup, support, or security guidance changed.

…twork-interface-name parameter.

…fix-vm-create-default-vnet-prefix

Copilot

🟡 Changes recommended

Network defaults can overwrite existing VNet address spaces and subnets, while direct secret interpolation into PowerShell risks credential corruption or unintended script interpretation.

4 open issues

What changed in this PR

This PR addresses #1338 by adding default network settings to the shared VM-creation orchestration used by CLI and PowerShell. It also removes explicit NIC naming in favor of {vm}VMNic.

Changes:

Add default VNet and subnet address prefixes and a default subnet name.
Remove the NIC-name parameter and update documentation, tests, benchmarks, and agent examples.
Adjust test VM sizes and the SDK pin, and add a service-principal sign-in workflow.

File	Description
wiki/01-getting-started/powershell-usage.md	Remove explicit NIC naming from the example.
tools/Help/Azclips.Help.Tool.Tests/Fixtures/cli-export/vm.json	Align exported help with automatic NIC naming.
tests/Scripts/PS/VMStop.ps1	Remove the NIC-name argument.
tests/Scripts/PS/VMShow.ps1	Remove the NIC-name argument.
tests/Scripts/PS/VMList.ps1	Remove the NIC-name argument.
tests/Scripts/PS/VMDelete.ps1	Remove the NIC-name argument.
tests/Scripts/PS/VMCreate.ps1	Update NIC expectations and VM sizes.
tests/Scripts/CLI/VMStop.sh	Remove the NIC-name flag.
tests/Scripts/CLI/VMShow.sh	Remove the NIC-name flag.
tests/Scripts/CLI/VMList.sh	Remove the NIC-name flag.
tests/Scripts/CLI/VMGetInstanceView.sh	Remove the NIC-name flag.
tests/Scripts/CLI/VMDelete.sh	Remove the NIC-name flag.
tests/Scripts/CLI/VMCreate.sh	Update NIC expectations and VM sizes.
tests/Scenario.Tests/Scripts/vm-create.sh	Use automatic NIC naming.
tests/Scenario.Tests/Scripts/vm-create.ps1	Use automatic NIC naming.
tests/Scenario.Tests/Scripts/vm-create-module.ps1	Use automatic NIC naming.
tests/Scenario.Tests/Compute/VmLifecycleScenarioTests.cs	Update creation inputs and PowerShell VM size.
tests/Scenario.Tests/Compute/VmCreateScenarioTests.cs	Update creation inputs, sizes, and NIC assertions.
tests/Scenario.Tests/Compute/VmCreateOrchestrationTests.cs	Align orchestration assertions with generated NIC names.
tests/Scenario.Tests/Compute/FakeVmArmBackend.cs	Return the generated NIC reference.
tests/Cmdlets.Tests/NewVMCmdletTests.cs	Remove references to the deleted parameter.
tests/Cli.Tests/VmCreateTests.cs	Remove obsolete NIC-name metadata assertions.
tests/Benchmark/PS/VirtualMachineBenchmarks.cs	Remove explicit NIC naming from benchmarks.
tests/Benchmark/CLI/VirtualMachineBenchmarks.cs	Remove explicit NIC naming from benchmarks.
src/PS/Compute/help/New-AzVM.md	Update syntax, examples, and parameter documentation.
src/PS/Compute/Cmdlets/NewVMCmdlet.cs	Remove the NIC-name parameter and forwarding.
src/Extensions/Compute/ExtensionIndex.cs	Remove NIC-name metadata from both surfaces.
src/Extensions/Compute/Customization/NewVMProcessor_Orchestrator.cs	Generate NIC names as `{vm}VMNic`.
src/Extensions/Compute/Customization/NewNetworkInterfaceProcessor_Orchestrator.cs	Add subnet-name and address-prefix defaults.
src/CLI/Help/Docs/vm/create.md	Document automatic NIC naming and update examples.
global.json	Change the SDK pin to `10.0.400`.
docs/pp-scenarios/scenario-2-vm-application.md	Remove NIC-name arguments from application examples.
Agent/eval/reference-cases.test.js	Update the reference VM command.
Agent/eval/cases/vm-create-short-flags.js	Remove the NIC-name argument requirement.
.github/workflows/bugbash006.yml	Add a manual PowerShell service-principal workflow.

_{Review effort: Balanced}

+        // Match legacy `az vm create`: default to 10.0.0.0/16 and a 10.0.0.0/24 first subnet.
+        List<string> addressPrefixes = AddressPrefixes.Count == 0 ? ["10.0.0.0/16"] : AddressPrefixes;
+        List<List<string>> subnetAddressPrefixes = [.. SubnetAddressPrefixes];
+        if (AddressPrefixes.Count == 0 && (subnetAddressPrefixes.Count == 0 || subnetAddressPrefixes[0].Count == 0))


Copilot

🟡 Changes recommended

Unresolved critical issues can overwrite existing VNet configuration during VM creation and execute unintended PowerShell through direct client-secret interpolation in the workflow.

5 open issues

2 resolved since last review

_{Review effort: Balanced}

Copilot

🟡 Changes recommended

The new VNet lookup exhausts recorded GET responses and breaks playback, while unresolved subnet-defaulting and PowerShell regressions cause provisioning, test, and smoke-script failures.

5 open issues

1 resolved since last review

Avoid applying creation defaults to existing VNets

_{Review effort: Balanced}

Copilot

🟡 Changes recommended

The PowerShell metadata incorrectly requires AdminPassword, contradicting supported SSH-key-only authentication and breaking the existing test that asserts the password is optional.

4 open issues

2 resolved since last review

_{Review effort: Balanced}

Copilot

🔵 Needs a closer look

The PowerShell confidential-VM smoke test defaults to an incompatible VM size, and regression coverage is missing for new-VNet networking defaults and existing-VNet reuse.

2 open issues

2 resolved since last review

_{Review effort: Balanced}

Copilot

🟡 Changes recommended

Supplying only a VNet prefix leaves the default subnet without an address range, the Confidential VM smoke test defaults to an unsupported SKU, and the new networking branches lack regression coverage.

2 open issues

1 resolved since last review

Remove NetworkInterfaceName from remaining PowerShell callers

_{Review effort: Balanced}

+            if (AddressPrefixes.Count == 0)
+            {
+                addressPrefixes = ["10.0.0.0/16"];
+                if (subnetAddressPrefixes.Count == 0)


JaysonTaiMicrosoft added 10 commits November 6, 2026 13:10

Add azps-cmdlets for testing

1c7e279

Add workflow

4bd1aba

Merge remote-tracking branch 'upstream/main'

75a40fa

Merge remote-tracking branch 'upstream/main'

8e51519

Merge remote-tracking branch 'upstream/main'

07fafc1

Merge remote-tracking branch 'upstream/main'

54c97da

Merge remote-tracking branch 'upstream/main'

f65232d

Merge remote-tracking branch 'upstream/main'

072bf39

Merge remote-tracking branch 'upstream/main'

b849435

Add default subnet address prefixes for creating vnet and remove --ne…

ce63684

…twork-interface-name parameter.

JaysonTaiMicrosoft requested review from a team, NoriZC, Yabo Hu (VeryEarly), Yeming Liu (isra-fel), Naga Nandyala (naga-nandyala), Ethan Yang (necusjz) and ZelinWang (wangzelin007) as code owners November 12, 2026 01:14

Copilot AI balanced review requested due to automatic review settings November 12, 2026 01:14

Copilot started reviewing on behalf of JaysonTaiMicrosoft November 12, 2026 01:14

View session

Merge remote-tracking branch 'upstream/main' into jaysontaimicrosoft-…

38e5d18

…fix-vm-create-default-vnet-prefix

Copilot AI reviewed Nov 12, 2026

View reviewed changes

Copilot AI balanced review requested due to automatic review settings November 12, 2026 01:20

remove bugbash workflow

ff4ed15

Copilot started reviewing on behalf of JaysonTaiMicrosoft November 12, 2026 01:20

View session

Copilot AI reviewed Nov 12, 2026

View reviewed changes

Comment thread src/Extensions/Compute/ExtensionIndex.cs Resolved

Comment thread src/PS/Compute/Cmdlets/NewVMCmdlet.cs Resolved

Comment thread tests/Scripts/PS/VMCreate.ps1 Resolved

Address comments

650ee1f

Copilot AI balanced review requested due to automatic review settings November 12, 2026 01:34

Copilot started reviewing on behalf of JaysonTaiMicrosoft November 12, 2026 01:35

View session

Copilot AI reviewed Nov 12, 2026

View reviewed changes

Comment thread src/Extensions/Compute/Customization/NewNetworkInterfaceProcessor_Orchestrator.cs Resolved

Re-record scenario tests

801f3fb

Copilot AI balanced review requested due to automatic review settings November 12, 2026 01:50

Copilot started reviewing on behalf of JaysonTaiMicrosoft November 12, 2026 01:50

View session

Copilot AI reviewed Nov 12, 2026

View reviewed changes

Comment thread src/Extensions/Compute/Customization/NewNetworkInterfaceProcessor_Orchestrator.cs Resolved

JaysonTaiMicrosoft added 2 commits November 12, 2026 13:01

Make admin password not required

0662c69

remove network name in sshcreate

2bdc882

Copilot AI balanced review requested due to automatic review settings November 12, 2026 02:02

Copilot started reviewing on behalf of JaysonTaiMicrosoft November 12, 2026 02:02

View session

Copilot AI reviewed Nov 12, 2026

View reviewed changes

Remove global json update

0cd31c4

Copilot AI balanced review requested due to automatic review settings November 12, 2026 02:11

remove testing release tar

9c16955

Copilot started reviewing on behalf of JaysonTaiMicrosoft November 12, 2026 02:11

View session

JaysonTaiMicrosoft self-assigned this Nov 12, 2026

JaysonTaiMicrosoft requested review from a team and DanielMicrosoft November 12, 2026 02:13

Copilot AI reviewed Nov 12, 2026

View reviewed changes

Comment thread src/Extensions/Compute/Customization/NewNetworkInterfaceProcessor_Orchestrator.cs

Comment on lines +158 to +161

if (AddressPrefixes.Count == 0)

{

addressPrefixes = ["10.0.0.0/16"];

if (subnetAddressPrefixes.Count == 0)

Navigation Menu

Repository navigation

[Compute] Add default subnet address prefixes when not specified - #1412

[Compute] Add default subnet address prefixes when not specified#1412
JaysonTaiMicrosoft wants to merge 18 commits into
mainfrom
jaysontaimicrosoft-fix-vm-create-default-vnet-prefix

JaysonTaiMicrosoft commented Nov 12, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

JaysonTaiMicrosoft commented Nov 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

JaysonTaiMicrosoft commented Nov 12, 2026 •

edited

Loading