Skip to content

feat: Add proper validation for non-compliance messages in policy assignments #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ASHR4 merged 3 commits into from
Apr 7, 2026
Merged

feat: Add proper validation for non-compliance messages in policy assignments #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15cceeb
feat: add validation for default non-compliance messages in policy as…
Mar 27, 2026
79e07db
Update assets/policyAssignment.go
ASHR4 Mar 27, 2026
a9f5a23
feat: enhance validation in ValidatePolicyAssignment to handle nil no…
Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions assets/policyAssignment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,35 @@ func ValidatePolicyAssignment(pa *PolicyAssignment) error {
pa.Properties.Overrides = make([]*armpolicy.Override, 0)
}

if pa.Properties.NonComplianceMessages == nil {
pa.Properties.NonComplianceMessages = make([]*armpolicy.NonComplianceMessage, 0)
}

var defaultNonComplianceMessageCount int

for _, msg := range pa.Properties.NonComplianceMessages {
if msg == nil {
return fmt.Errorf(
"ValidatePolicyAssignment: policy assignment %s has a nil non-compliance message entry",
*pa.Name,
)
}

if msg.PolicyDefinitionReferenceID == nil || *msg.PolicyDefinitionReferenceID == "" {
defaultNonComplianceMessageCount++
if defaultNonComplianceMessageCount > 1 {
break
}
}
}
Comment thread
ASHR4 marked this conversation as resolved.

if defaultNonComplianceMessageCount > 1 {
return fmt.Errorf(
"ValidatePolicyAssignment: policy assignment %s has more than 1 default non-compliance messages, only 1 is allowed",
*pa.Name,
)
Comment thread
ASHR4 marked this conversation as resolved.
}

if pa.Properties.Parameters == nil {
pa.Properties.Parameters = make(map[string]*armpolicy.ParameterValuesValue)
}
Expand Down
72 changes: 72 additions & 0 deletions assets/policyAssignment_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,78 @@ func TestValidatePolicyAssignment(t *testing.T) {
},
expectedErr: "property 'properties.description' length must be between 1 and 512, but is 0",
},
{
name: "Single default non-compliance message",
assignment: armpolicy.Assignment{
Name: to.Ptr("validName"),
Properties: &armpolicy.AssignmentProperties{
PolicyDefinitionID: to.Ptr(
"/subscriptions/123/resourceGroups/rg1/providers/Microsoft.Authorization/policyDefinitions/pd1",
),
DisplayName: to.Ptr("Valid Display Name"),
Description: to.Ptr("Valid Description"),
NonComplianceMessages: []*armpolicy.NonComplianceMessage{
{Message: to.Ptr("default message")},
{Message: to.Ptr("ref message"), PolicyDefinitionReferenceID: to.Ptr("ref1")},
},
},
},
expectedErr: "",
},
{
name: "Multiple default non-compliance messages",
assignment: armpolicy.Assignment{
Name: to.Ptr("validName"),
Properties: &armpolicy.AssignmentProperties{
PolicyDefinitionID: to.Ptr(
"/subscriptions/123/resourceGroups/rg1/providers/Microsoft.Authorization/policyDefinitions/pd1",
),
DisplayName: to.Ptr("Valid Display Name"),
Description: to.Ptr("Valid Description"),
NonComplianceMessages: []*armpolicy.NonComplianceMessage{
{Message: to.Ptr("default message 1")},
{Message: to.Ptr("default message 2")},
},
},
},
expectedErr: "has more than 1 default non-compliance messages, only 1 is allowed",
},
{
name: "Multiple default non-compliance messages with empty reference ID",
assignment: armpolicy.Assignment{
Name: to.Ptr("validName"),
Properties: &armpolicy.AssignmentProperties{
PolicyDefinitionID: to.Ptr(
"/subscriptions/123/resourceGroups/rg1/providers/Microsoft.Authorization/policyDefinitions/pd1",
),
DisplayName: to.Ptr("Valid Display Name"),
Description: to.Ptr("Valid Description"),
NonComplianceMessages: []*armpolicy.NonComplianceMessage{
{Message: to.Ptr("default message 1")},
{Message: to.Ptr("default message 2"), PolicyDefinitionReferenceID: to.Ptr("")},
},
},
},
expectedErr: "has more than 1 default non-compliance messages, only 1 is allowed",
},
{
name: "Nil element in non-compliance messages slice",
assignment: armpolicy.Assignment{
Name: to.Ptr("validName"),
Properties: &armpolicy.AssignmentProperties{
PolicyDefinitionID: to.Ptr(
"/subscriptions/123/resourceGroups/rg1/providers/Microsoft.Authorization/policyDefinitions/pd1",
),
DisplayName: to.Ptr("Valid Display Name"),
Description: to.Ptr("Valid Description"),
NonComplianceMessages: []*armpolicy.NonComplianceMessage{
nil,
{Message: to.Ptr("ref message"), PolicyDefinitionReferenceID: to.Ptr("ref1")},
},
},
},
expectedErr: "has a nil non-compliance message entry",
},
Comment thread
ASHR4 marked this conversation as resolved.
}

for _, tt := range tests {
Expand Down
Loading