Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Change
build-onlyso it still compiles and installs the NVIDIA kernel modules and userspace libraries, but does not register NVIDIA with DKMS in the shared VHD.--no-dkmsonly in build-only mode. Keep normal CUDA and GRID installation on--dkms./lib/modules/<target-kernel>/updates/dkms. This preserves the path used by AgentBaker's existing CPU/GRID cleanup when the installer no longer uses DKMS's Ubuntu destination.This is the aks-gpu part of an alternative safety-only approach to Azure/AgentBaker#9545. It does not park or restore DKMS state.
Why
A shared VHD can become a CPU or opted-out GPU node. If that VHD contains active NVIDIA DKMS registration and node-time cleanup fails, a later kernel update can trigger an unwanted NVIDIA build.
Build-only must leave no active NVIDIA DKMS registration. The published image's safety must not depend on successful cleanup during node provisioning. Driver files still exist; this is not a driver-file removal change.
Compatibility and rollout — draft
.kofiles to skip compilation. Validation-only CUDA nodes can require a full installation instead of restore-and-validate, so provisioning performance must be measured before rollout.install-skip-buildimplementation is unchanged and is not used by AgentBaker. It needs separate DKMS-state handling before it can safely consume these unregistered prebakes.Validation
shellcheck -S warning install.sh entrypoint.shpasses.bats test/install.bats: 23 tests pass on host Bash and Linux Bash in a disposable container.