Repository navigation
fix: upgrade ca-certificates instead of using dnf install - #9878
Merged
Nishchay (awesomenix) merged 2 commits intoOct 23, 2026
Merged
Nishchay (awesomenix) merged 2 commits into
Nishchay (awesomenix) merged 2 commits into
Conversation
Nishchay (awesomenix)
had a problem deploying
to
test
October 23, 2026 00:59 — with 
GitHub Actions
Failure
GitHub Actions
Failure
Nishchay (awesomenix)
had a problem deploying
to
test
October 23, 2026 00:59 — with
GitHub Actions
Failure
GitHub Actions
Failure
Nishchay (awesomenix)
merged commit Oct 23, 2026
60dbc69
into
official/v20261016
13 of 15 checks passed
Nishchay (awesomenix)
deleted the
nishp/update-ca-certificates-20261016
branch
October 23, 2026 00:59
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The changed upgrade command and failure handling need focused ShellSpec regression coverage.
1 open issue
What changed in this PR
This PR changes CA certificate updates during Linux node provisioning to use dnf upgrade rather than dnf install.
Changes:
- Use the retry helper to upgrade
ca-certificateson eligible Mariner/Azure Linux nodes. - Bump the node-controller hotfix scripts version to
202610.16.4.
| File | Description |
|---|---|
parts/linux/cloud-init/artifacts/cse_main.sh |
Replace certificate installation with a retried upgrade. |
parts/linux/cloud-init/artifacts/aks-node-controller-hotfix.json |
Advance the hotfix scripts version. |
Review effort: Balanced
| apt_get_install 30 1 600 ca-certificates || return "$ERR_APT_INSTALL_TIMEOUT" | ||
| elif isMarinerOrAzureLinux "$OS" && ! isAzureLinuxOSGuard "$OS" "$OS_VARIANT"; then | ||
| dnf_install 30 1 600 --refresh ca-certificates || return "$ERR_APT_INSTALL_TIMEOUT" | ||
| retrycmd_if_failure 30 1 600 dnf upgrade -y --refresh ca-certificates || return "$ERR_APT_INSTALL_TIMEOUT" |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
call upgrade instead of install