Repository navigation
feat: report entire provision output from ANC - #9877
Merged
Merged
Conversation
Contributor
Windows Unit Test Results 3 files 18 suites 59s ⏱️ Results for commit b283933. ♻️ This comment has been updated with latest results. |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Compatibility of the expanded JSON descriptions with production WireServer and diagnostic consumers still needs human validation.
No open issues 🎉
What changed in this PR
This PR improves aks-node-controller provisioning failure reports by including structured CSE output rather than only an exit code and error.
Changes:
- Extracts matching CSE JSON from command output, with captured result fields as a fallback.
- Limits WireServer descriptions to 4,096 XML-escaped bytes, preserving output tails and marking truncated content.
- Adds extraction, truncation, and reporting tests, and documents the behavior.
| File | Description |
|---|---|
| aks-node-controller/README.md | Documents failure payloads and truncation limits. |
| aks-node-controller/provision_status.go | Extracts and bounds structured failure descriptions. |
| aks-node-controller/provision_status_test.go | Tests extraction, fallback, truncation, and reporting integration. |
| aks-node-controller/goal_state.go | Applies the larger XML-aware WireServer description limit. |
| aks-node-controller/goal_state_test.go | Tests description limits and Unicode handling. |
| aks-node-controller/app.go | Integrates structured descriptions into failure reporting. |
| aks-node-controller/app_test.go | Updates reporting assertions for JSON descriptions. |
Review effort: Balanced
Nishchay (awesomenix)
approved these changes
Oct 23, 2026
…add-verbose-provision-output
Abigail Liang (abigailliang-aks-sig-node)
approved these changes
Oct 23, 2026
Contributor
|
Contributor
|
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Return entire error message from cse stdout instead of just the exit code when reporting provisioning status from ANC.
Which issue(s) this PR fixes:
Fixes #