Skip to content

docs(cse_main): document risk-acceptance for unquoted OUTBOUND_COMMAND #9876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Calvin S. (calvin197) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs(cse_main): document risk-acceptance for unquoted OUTBOUND_COMMAND #9876

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions parts/linux/cloud-init/artifacts/cse_main.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,6 +457,12 @@ function nodePrep {
fi

if [ -n "${OUTBOUND_COMMAND}" ]; then
# OUTBOUND_COMMAND is intentionally expanded unquoted here (not a scanner oversight):
# it is a full shell command (e.g. `curl -v --insecure --proxy-insecure <url>`) built by
# the RP from config.OutboundType/CloudSpecConfig (see GetOutboundCommand in baker.go),
# not an arbitrary string from an external caller. Quoting it would break word-splitting
# into argv and make the outbound connectivity check fail to execute. Do not add quotes
# here without also changing it to an array (e.g. OUTBOUND_COMMAND=(...)) end to end.
retrycmd_if_failure 20 1 15 $OUTBOUND_COMMAND >> /var/log/azure/cluster-provision-cse-output.log 2>&1 || exit $ERR_OUTBOUND_CONN_FAIL;
fi
if [ -n "${BOOTSTRAP_PROFILE_CONTAINER_REGISTRY_SERVER}" ]; then
Expand Down
Loading