Skip to content

feat(aks-node-controller): support additional Linux sysctl settings - #9856

Merged
Nishchay (awesomenix) merged 2 commits into
mainfrom
sharsha/LinuxOSBootStrapUserData
Oct 22, 2026
Merged

Nishchay (awesomenix) merged 2 commits into
mainfrom
sharsha/LinuxOSBootStrapUserData

Conversation

@SriHarsha001

@SriHarsha001 Sri Harsha (SriHarsha001) commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Extend the Linux sysctl protobuf schema with optional fields:
net_ipv4_tcp_retries2
fs_inotify_max_user_instances
net_ipv4_ip_local_reserved_ports
net_ipv4_tcp_rmem

Which issue(s) this PR fixes:

Fixes #

Copilot AI balanced review requested due to automatic review settings October 21, 2026 22:59
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedOct 21, 2026, 11:30 PM

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Windows Unit Test Results

  3 files   18 suites   1m 8s ⏱️
563 tests 563 ✅ 0 💤 0 ❌
585 runs  585 ✅ 0 💤 0 ❌

Results for commit 2ea9c8c.

♻️ This comment has been updated with latest results.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Static review identified no blocking issues in the additive schema changes, rendering logic, or focused regression coverage.

No open issues 🎉

1 file not reviewed
  • aks-node-controller/pkg/gen/aksnodeconfig/v1/custom_linux_os_config.pb.go: Generated file
What changed in this PR

Extends aks-node-controller’s Linux configuration support with four additional sysctl settings while preserving existing defaults.

Changes:

  • Adds optional settings for TCP retries, TCP receive buffers, inotify instances, and reserved local ports.
  • Renders the new settings and merges customer port reservations with the existing automatic reservation.
  • Adds serialization round-trip and reservation-merging regression tests.
File Description
aks-node-controller/​proto/​aksnodeconfig/​v1/​custom_linux_os_config.proto Defines four optional sysctl fields.
aks-node-controller/​pkg/​gen/​aksnodeconfig/​v1/​custom_linux_os_config.pb.go Updates generated Go bindings and descriptors.
aks-node-controller/​parser/​helper.go Renders new settings and merges reserved ports.
aks-node-controller/​parser/​helper_test.go Tests serialization, field presence, defaults, and port reservations.

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings October 21, 2026 23:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Note

This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.

@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage

Package Line Rate Health
test 0% ❌
windows 27% ❌
staging_cse_windows Package 1 65% ➖
debug 0% ❌
provisioningscripts 2% ❌
parts_windows Package 1 73% ➖
Summary 38% (1652 / 6834) ❌

@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage

Package Line Rate Health
github.com/Azure/agentbaker/aks-node-controller 72% ➖
github.com/Azure/agentbaker/aks-node-controller/common 100% ✔
github.com/Azure/agentbaker/aks-node-controller/helpers 68% ➖
github.com/Azure/agentbaker/aks-node-controller/parser 88% ✔
github.com/Azure/agentbaker/aks-node-controller/pkg/gpu 100% ✔
github.com/Azure/agentbaker/aks-node-controller/pkg/nodeconfigutils 89% ✔
github.com/Azure/agentbaker/aks-node-controller/utils 0% ❌
github.com/Azure/agentbaker/apiserver 24% ❌
github.com/Azure/agentbaker/cmd 0% ❌
github.com/Azure/agentbaker/cmd/starter 0% ❌
github.com/Azure/agentbaker/fuzz/api 0% ❌
github.com/Azure/agentbaker/hotfix/render-nodecustomdata 0% ❌
github.com/Azure/agentbaker/pkg/agent 78% ➖
github.com/Azure/agentbaker/pkg/agent/datamodel 77% ➖
github.com/Azure/agentbaker/pkg/agent/toggles 0% ❌
github.com/Azure/agentbaker/pkg/vhdbuilder/datamodel 87% ✔
Summary 75% (5873 / 7861) ➖

@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage

Package Line Rate Health
shellspec spec 28% ❌
Summary 28% (4556 / 15971) ❌

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The additive changes preserve existing defaults, include focused regression coverage, and have no identified blocking issues.

No open issues 🎉

1 file not reviewed
  • aks-node-controller/pkg/gen/aksnodeconfig/v1/custom_linux_os_config.pb.go: Generated file

Review effort: Balanced

@awesomenix
Nishchay (awesomenix) merged commit e9215be into main Oct 22, 2026
39 of 42 checks passed
@awesomenix
Nishchay (awesomenix) deleted the sharsha/LinuxOSBootStrapUserData branch October 22, 2026 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants