Repository navigation
feat(aks-node-controller): support additional Linux sysctl settings - #9856
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
Windows Unit Test Results 3 files 18 suites 1m 8s ⏱️ Results for commit 2ea9c8c. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
🟢 Approval recommended
Static review identified no blocking issues in the additive schema changes, rendering logic, or focused regression coverage.
No open issues 🎉
1 file not reviewed
aks-node-controller/pkg/gen/aksnodeconfig/v1/custom_linux_os_config.pb.go: Generated file
What changed in this PR
Extends aks-node-controller’s Linux configuration support with four additional sysctl settings while preserving existing defaults.
Changes:
- Adds optional settings for TCP retries, TCP receive buffers, inotify instances, and reserved local ports.
- Renders the new settings and merges customer port reservations with the existing automatic reservation.
- Adds serialization round-trip and reservation-merging regression tests.
| File | Description |
|---|---|
| aks-node-controller/proto/aksnodeconfig/v1/custom_linux_os_config.proto | Defines four optional sysctl fields. |
| aks-node-controller/pkg/gen/aksnodeconfig/v1/custom_linux_os_config.pb.go | Updates generated Go bindings and descriptors. |
| aks-node-controller/parser/helper.go | Renders new settings and merges reserved ports. |
| aks-node-controller/parser/helper_test.go | Tests serialization, field presence, defaults, and port reservations. |
Review effort: Balanced
There was a problem hiding this comment.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Note
This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.
|
There was a problem hiding this comment.
🟢 Approval recommended
The additive changes preserve existing defaults, include focused regression coverage, and have no identified blocking issues.
No open issues 🎉
1 file not reviewed
aks-node-controller/pkg/gen/aksnodeconfig/v1/custom_linux_os_config.pb.go: Generated file
Review effort: Balanced
What this PR does / why we need it:
Extend the Linux sysctl protobuf schema with optional fields:
net_ipv4_tcp_retries2
fs_inotify_max_user_instances
net_ipv4_ip_local_reserved_ports
net_ipv4_tcp_rmem
Which issue(s) this PR fixes:
Fixes #