Skip to content

fix: configure packages endpoints when repo depot is set (#9828) - #9851

Merged
Nishchay (awesomenix) merged 2 commits into
official/v20261008from
nishp/cherrypick/1008
Oct 21, 2026
Merged

Nishchay (awesomenix) merged 2 commits into
official/v20261008from
nishp/cherrypick/1008

Conversation

@awesomenix

Copy link
Copy Markdown
Contributor

cherry-pick PR to mitigate aks cloud problems

@github-actions

Copy link
Copy Markdown
Contributor

Windows Unit Test Results

  3 files   18 suites   1m 3s ⏱️
551 tests 551 ✅ 0 💤 0 ❌
554 runs  554 ✅ 0 💤 0 ❌

Results for commit 2738af1.

@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage

Package Line Rate Health
parts_windows Package 1 76% ➖
staging_cse_windows Package 1 65% ➖
debug 0% ❌
provisioningscripts 2% ❌
test 0% ❌
windows 27% ❌
Summary 39% (1663 / 6838) ❌

@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage

Package Line Rate Health
github.com/Azure/agentbaker/aks-node-controller 71% ➖
github.com/Azure/agentbaker/aks-node-controller/common 100% ✔
github.com/Azure/agentbaker/aks-node-controller/helpers 68% ➖
github.com/Azure/agentbaker/aks-node-controller/parser 87% ✔
github.com/Azure/agentbaker/aks-node-controller/pkg/gpu 100% ✔
github.com/Azure/agentbaker/aks-node-controller/pkg/nodeconfigutils 70% ➖
github.com/Azure/agentbaker/aks-node-controller/utils 0% ❌
github.com/Azure/agentbaker/apiserver 24% ❌
github.com/Azure/agentbaker/cmd 0% ❌
github.com/Azure/agentbaker/cmd/starter 0% ❌
github.com/Azure/agentbaker/fuzz/api 0% ❌
github.com/Azure/agentbaker/hotfix/render-nodecustomdata 0% ❌
github.com/Azure/agentbaker/pkg/agent 76% ➖
github.com/Azure/agentbaker/pkg/agent/datamodel 76% ➖
github.com/Azure/agentbaker/pkg/agent/toggles 0% ❌
github.com/Azure/agentbaker/pkg/vhdbuilder/datamodel 87% ✔
Summary 73% (5337 / 7327) ➖

@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage

Package Line Rate Health
shellspec spec 22% ❌
Summary 22% (3183 / 14365) ❌

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

A fatal Ubuntu repository check can prevent certificate-refresh registration while provisioning continues.

1 open issue
What changed in this PR

This cherry-pick fixes RepoDepot initialization during Linux node provisioning so it no longer depends on certificate-refresh eligibility.

Changes:

  • Moves repository setup before the certificate-refresh guard and removes cloud-init waits.
  • Adds package-cache retries and failure reporting.
  • Adds ShellSpec coverage for dispatch and retry behavior.
File Description
spec/​parts/​linux/​cloud-init/​artifacts/​init_aks_cloud_spec.sh Tests repository dispatch, cache retries, and non-fatal cache failures.
parts/​linux/​cloud-init/​artifacts/​init-aks-cloud.sh Separates repository initialization from certificate eligibility and updates cache handling.

Review effort: Balanced

ubuntuRel=$(lsb_release --release | awk '{print $2}')
ubuntuDist=$(lsb_release -c | awk '{print $2}')
init_ubuntu_main_repo_depot ${rootRepoDepotEndpoint}
init_ubuntu_pmc_repo_depot ${rootRepoDepotEndpoint}
@awesomenix
Nishchay (awesomenix) merged commit 2950300 into official/v20261008 Oct 21, 2026
19 of 33 checks passed
@awesomenix
Nishchay (awesomenix) deleted the nishp/cherrypick/1008 branch October 21, 2026 20:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Repository URL failures can prevent certificate-refresh registration while legacy provisioning continues.

1 open issue

Review effort: Balanced

This branch had an error being deployed

1 failed deployment
test — ef643f3c Deployed Oct 21, 2026 by awesomenix via hotfix-generate #1000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants