Skip to content

feat: add Azure Container Linux CVM FIPS image - #9777

Merged
Nishchay (awesomenix) merged 4 commits into
mainfrom
ankitapareek/acl-cvm-fips
Oct 23, 2026
Merged

Nishchay (awesomenix) merged 4 commits into
mainfrom
ankitapareek/acl-cvm-fips

Conversation

@Ankita13-code

@Ankita13-code Ankita Pareek (Ankita13-code) commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

What type of PR is this?

/area agentbaker
/area vhd
/kind feature

What this PR does / why we need it

Adds the dedicated aks-acl-cvm-gen2-fips distro and aclgen2fipsCVM SIG definition. Adds an x64 release job that builds through the ACL CVM path with FEATURE_FLAGS=cvm and ENABLE_FIPS=True.

The new definition remains excluded from GetMaintainedLinuxSIGImageConfigMap until its first image version is published.

Which issue(s) this PR fixes

Part of Azure Container Linux Confidential VM + FIPS enablement.

Requirements

  • Unit tests updated and passing (go test ./pkg/agent/datamodel ./pkg/agent)
  • Release YAML parses successfully
  • First aclgen2fipsCVM image version published before removing the maintained-map skip

The commit was created through GitHub and has a valid GitHub-verified signature.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Windows Unit Test Results

  3 files   18 suites   1m 7s ⏱️
563 tests 563 ✅ 0 💤 0 ❌
585 runs  585 ✅ 0 💤 0 ❌

Results for commit f7d9dae.

♻️ This comment has been updated with latest results.

Register the dedicated ACL CVM FIPS distro and SIG definition, and add a release job that builds the CVM image with FIPS enabled.

Co-authored-by: Ankita Pareek <56152556+Ankita13-code@users.noreply.github.com>

Signed-off-by: Aadhar Agarwal <aadagarwal@microsoft.com>
Signed-off-by: Aadhar Agarwal <aadagarwal@microsoft.com>
@aadhar-agarwal
aadhar-agarwal force-pushed the ankitapareek/acl-cvm-fips branch from 7aae2c9 to 6d0785a Compare October 21, 2026 00:50
@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage

Package Line Rate Health
github.com/Azure/agentbaker/aks-node-controller 72% ➖
github.com/Azure/agentbaker/aks-node-controller/common 100% ✔
github.com/Azure/agentbaker/aks-node-controller/helpers 68% ➖
github.com/Azure/agentbaker/aks-node-controller/parser 88% ✔
github.com/Azure/agentbaker/aks-node-controller/pkg/gpu 100% ✔
github.com/Azure/agentbaker/aks-node-controller/pkg/nodeconfigutils 89% ✔
github.com/Azure/agentbaker/aks-node-controller/utils 0% ❌
github.com/Azure/agentbaker/apiserver 24% ❌
github.com/Azure/agentbaker/cmd 0% ❌
github.com/Azure/agentbaker/cmd/starter 0% ❌
github.com/Azure/agentbaker/fuzz/api 0% ❌
github.com/Azure/agentbaker/hotfix/render-nodecustomdata 0% ❌
github.com/Azure/agentbaker/pkg/agent 78% ➖
github.com/Azure/agentbaker/pkg/agent/datamodel 77% ➖
github.com/Azure/agentbaker/pkg/agent/toggles 0% ❌
github.com/Azure/agentbaker/pkg/vhdbuilder/datamodel 87% ✔
Summary 75% (5874 / 7862) ➖

@mayankfz
mayankfz marked this pull request as ready for review October 22, 2026 14:10
@mayankfz
mayankfz requested review from a team as code owners October 22, 2026 14:10
Copilot AI balanced review requested due to automatic review settings October 22, 2026 14:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The security-sensitive CVM/FIPS combination needs human review of a successful image build, Confidential VM boot, and FIPS validation.

No open issues 🎉

What changed in this PR

Adds an Azure Container Linux Confidential VM (CVM) FIPS image option to AgentBaker’s distro catalog and VHD release pipeline.

Changes:

  • Registers aks-acl-cvm-gen2-fips and its aclgen2fipsCVM image definition, excluding it from the maintained-image map until first publication.
  • Adds an opt-in x64 release job using the CVM build path with FIPS enabled.
  • Extends distro classification, image configuration, and API tests.
File Description
pkg/​agent/​datamodel/​types.go Declares and registers the new distro.
pkg/​agent/​datamodel/​types_test.go Tests ACL classification for the new distro.
pkg/​agent/​datamodel/​sig_config.go Adds image mapping, capability lists, and publication skip.
pkg/​agent/​datamodel/​sig_config_test.go Updates image configuration expectations.
pkg/​agent/​bakerapi_test.go Includes the distro in API test coverage.
.pipelines/​.vsts-vhd-builder-release.yaml Adds the optional x64 CVM FIPS build job.

Review effort: Balanced

Parameterize the CVM FIPS job source gallery, image definition, and version so ACL validation runs use the selected release instead of a stale hardcoded image.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 23, 2026 08:19
@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage

Package Line Rate Health
test 0% ❌
windows 27% ❌
staging_cse_windows Package 1 65% ➖
debug 0% ❌
provisioningscripts 2% ❌
parts_windows Package 1 73% ➖
Summary 38% (1652 / 6834) ❌

@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage

Package Line Rate Health
shellspec spec 28% ❌
Summary 28% (4591 / 16082) ❌

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The combined CVM/FIPS image needs human confirmation of successful image building, confidential-VM boot, and runtime FIPS validation beyond the reported unit tests and YAML parsing.

No open issues 🎉

Review effort: Balanced

@Ankita13-code

Copy link
Copy Markdown
Contributor Author

P0 request: this image-path change needs to merge by October 26. @Azure/agentbakeradmin Sylvain Boily (@djsly) Cameron Meissner (@cameronmeissner), could you please review the ACL CVM + FIPS distro/SIG/pipeline wiring?

The only failing required check is go-test: TestLivePatchingUsesVHDInsteadOfCustomData reports 87404 encoded characters vs the existing 87380 limit. The identical 87404 failure is present on unrelated run https://github.com/Azure/AgentBaker/actions/runs/39921623927, while this PR's latest commit changes only .pipelines/.vsts-vhd-builder-release.yaml; the focused test passes locally 10/10. I reran CI and reproduced the same runner-wide failure. Please advise/fix the shared regression or apply the repository-approved check disposition; I do not propose weakening the custom-data limit in this feature PR.

@awesomenix
Nishchay (awesomenix) merged commit 6b5eaf6 into main Oct 23, 2026
31 of 33 checks passed
@awesomenix
Nishchay (awesomenix) deleted the ankitapareek/acl-cvm-fips branch October 23, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants