Configure kubelet through generated configuration - #263
Merged
Conversation
hbc (bcho)
commented
Aug 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Maps FlexNode-managed kubelet settings into Unbounded’s generated configuration and adds exec image credential provider support.
Changes:
- Maps max pods, image GC thresholds, and verbosity into
KubeletConfiguration. - Adds credential provider configuration, validation, documentation, and tests.
- Updates Unbounded and Kubernetes dependencies.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
pkg/config/config.go |
Adds credential provider schema and validation. |
pkg/config/adapter.go |
Maps kubelet settings into agent configuration. |
pkg/config/adapter_test.go |
Tests agent configuration mapping. |
pkg/config/kubelet_config_test.go |
Tests JSON parsing and provider validation. |
pkg/config/copy_test.go |
Verifies provider configuration is deeply copied. |
docs/usages/configuration.md |
Documents provider configuration and mounts. |
go.mod |
Updates Unbounded and Kubernetes dependencies. |
go.sum |
Updates dependency checksums. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Thalia Wang (wenxuan0923)
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maxPods, verbosity, and image GC thresholds) into Unbounded's generatedKubeletConfigurationDependency
This is pinned to the current head of draft upstream PR Azure/unbounded#573. Replace the pseudo-version with the containing Unbounded release after that PR merges.
Testing
make check