Skip to content

Configure kubelet through generated configuration - #263

Merged
hbc (bcho) merged 4 commits into
mainfrom
hbc/kubelet-flag
Aug 7, 2026
Merged

Configure kubelet through generated configuration#263
hbc (bcho) merged 4 commits into
mainfrom
hbc/kubelet-flag

Conversation

@bcho

@bcho hbc (bcho) commented Aug 4, 2026

Copy link
Copy Markdown
Member

Summary

  • map the controlled FlexNode kubelet settings (maxPods, verbosity, and image GC thresholds) into Unbounded's generated KubeletConfiguration
  • expose optional kubelet exec image credential provider config and binary paths without exposing arbitrary kubelet configuration
  • keep Machine goal ownership and persistence unchanged; Azure-side max pods and image GC settings are immutable, and broader authoritative goal handling remains tracked by Make ARM Machine goals authoritative and acknowledge RP node updates #256
  • document credential provider rootfs/read-only mount setup and add validation, adapter, and copy coverage

Dependency

This is pinned to the current head of draft upstream PR Azure/unbounded#573. Replace the pseudo-version with the containing Unbounded release after that PR merges.

Testing

  • make check

Comment thread go.mod Outdated
@bcho
hbc (bcho) requested a balanced review from Copilot August 7, 2026 21:20
@bcho
hbc (bcho) marked this pull request as ready for review August 7, 2026 21:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Maps FlexNode-managed kubelet settings into Unbounded’s generated configuration and adds exec image credential provider support.

Changes:

  • Maps max pods, image GC thresholds, and verbosity into KubeletConfiguration.
  • Adds credential provider configuration, validation, documentation, and tests.
  • Updates Unbounded and Kubernetes dependencies.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pkg/config/config.go Adds credential provider schema and validation.
pkg/config/adapter.go Maps kubelet settings into agent configuration.
pkg/config/adapter_test.go Tests agent configuration mapping.
pkg/config/kubelet_config_test.go Tests JSON parsing and provider validation.
pkg/config/copy_test.go Verifies provider configuration is deeply copied.
docs/usages/configuration.md Documents provider configuration and mounts.
go.mod Updates Unbounded and Kubernetes dependencies.
go.sum Updates dependency checksums.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pkg/config/config.go
Copilot AI review requested due to automatic review settings August 7, 2026 21:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated no new comments.

@bcho
hbc (bcho) merged commit 3d53906 into main Aug 7, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants