fix: warn about pending governance withdrawals on vault card#64
Open
robertbrada wants to merge 1 commit intomainfrom
Open
fix: warn about pending governance withdrawals on vault card#64robertbrada wants to merge 1 commit intomainfrom
robertbrada wants to merge 1 commit intomainfrom
Conversation
…ithdrawal Adds an amber warning under the Withdraw button on each Token Vault card when the vault has unfinalized governance withdrawals. Tokens initiated for withdrawal from Governance stay with the Governance contract until finalize() is called, so they cannot be withdrawn to the wallet via the vault — the warning links directly to the external governance dashboard. Also clarifies the Available to Withdraw tooltip to explain that tokens held in Governance are not counted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users often try to withdraw from a Token Vault to their wallet while they still have unfinalized governance withdrawals. Until those are finalized, the tokens are held by the Governance contract and cannot be released by a vault withdrawal.
This adds an amber line on the Token Vault card linking directly to the governance dashboard to finalize, and clarifies the "Available to Withdraw" tooltip.