fix(bb-prover): replace a dead pooled bb verifier (port aztec-labs-eng/aztec-node#354 to v6) - #25590
Closed
charlielye wants to merge 1 commit into
Closed
charlielye wants to merge 1 commit into
charlielye wants to merge 1 commit into
Conversation
…g/aztec-node#354 to v6) Carries aztec-labs-eng/aztec-node#354 as a labs patch on v6. The bb.js side it relies on, #25548, is already on v6 via the rolling port in #25565. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NuUzj3qpkpJor6GMpWB4T4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports aztec-labs-eng/aztec-node#354 to
v6as a labs patch,labs-patches/0011-….#354 fixes the RPC proof verifier's pool. When a pooled
bbdied, the pool kept handing out the dead handle for the life of the node, andverifyProofreported the failure as{ valid: false }, so valid transactions were rejected as having invalid proofs until restart. With the fix:bbprocess when it dies, using bb.js'srespawn.bbdied or could not start is retried once, then fails asProofVerifierUnavailableErrorinstead of as an invalid proof.bbon first use.The bb.js half it relies on, #25548, is already on
v6via the rolling port in #25565.v6builds labs against its own bb.js, so no pin change is needed.How
labsstays ata0d73c0aed. #354's squash commit (aztec-labs-eng/aztec-node@8556dfb6a6) is cherry-picked onto the existing series and exported, with no conflicts. The existing patches0001and0010are unchanged; the new one is numbered0011so it sorts after them.The patch drops out at the next
labsbump past aztec-nodemainat 8556dfb6a6.Verification
./labs-patches/bootstrap.sh check: the series applies cleanly to the gitlink.v6in this PR's CI.🤖 Generated with Claude Code
https://claude.ai/code/session_01NuUzj3qpkpJor6GMpWB4T4