feat(archiver): handle multiple proposed checkpoints#22784
Merged
PhilWindle merged 2 commits intomerge-train/spartanfrom Apr 28, 2026
Merged
feat(archiver): handle multiple proposed checkpoints#22784PhilWindle merged 2 commits intomerge-train/spartanfrom
PhilWindle merged 2 commits intomerge-train/spartanfrom
Conversation
spalladino
added
the
ci-no-fail-fast
addProposedBlock was checking only the latest confirmed checkpoint as the valid parent, rejecting any block whose checkpointNumber - 1 was a pending (not yet mined) checkpoint. With multiple pending checkpoints in the queue, this caused BlockCheckpointNumberNotSequentialError when the proposer pipelined into a new checkpoint while the previous one was still pending. Accept the block when the expected predecessor matches a pending entry, and report max(confirmed, latest pending) in the error otherwise. Fixes the e2e regressions in epochs_mbps.pipeline.parallel and epochs_invalidate_block.parallel which both bottomed out on this check. Updates affected unit tests to use the renamed error classes BlockCheckpointNumberNotSequentialError and BlockOrCheckpointSlotExpiredError.
spalladino
force-pushed
the
spl/multiple-proposed-checkpoints
branch
from
ac0d28f to
88a5e2e
Compare
PhilWindle
approved these changes
Apr 28, 2026
ElusAegis
pushed a commit
to ElusAegis/aztec-packages
that referenced
this pull request
Apr 30, 2026
BEGIN_COMMIT_OVERRIDE chore: pass through p2p tx pool size (AztecProtocol#22804) feat: track sequencer state time (AztecProtocol#22800) feat(rpc)!: updated rpc api for blocks and checkpoints (AztecProtocol#22781) feat(pipelining): complete attestations by build-slot end (AztecProtocol#22735) feat(archiver): handle multiple proposed checkpoints (AztecProtocol#22784) feat: scrape bench-10tps (AztecProtocol#22803) feat!: make proposals EIP-712 (AztecProtocol#22531) chore: remove default env (AztecProtocol#22837) chore: remove default env (AztecProtocol#22839) chore: grafana provisioning (AztecProtocol#22843) feat: add extra getters (AztecProtocol#22563) fix: use number config helper for NaN protection (AztecProtocol#22598) test(e2e): relax blocks per checkpoint in high tps e2e (AztecProtocol#22846) test(e2e): equivocation recovery under proposer pipelining (AztecProtocol#22831) feat: scrape metrics data (AztecProtocol#22840) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the archiver data store model so that we can account for more than a single proposed checkpoint. Under pipelining, it's possible we receive the proposal for the next checkpoint before we've managed to sync the previous one from L1, thus having two checkpoints unmined.
Also fixes
addProposedCheckpointin the archiver so that it goes through the queue, instead of potentially injecting it in the middle of an L1 sync.Next steps is to review the archiver and node APIs that return checkpoints, and unify whether we return proposed checkpoints along mined checkpoints or not. Related to #22781.
Fixes A-910