Skip to content

fix custom UDFPs animations playing infinitely#43

Closed
Localhorst04 wants to merge 1 commit intoAxionAOSP:lineage-23.2from
Localhorst04:lineage-23.2
Closed

fix custom UDFPs animations playing infinitely#43
Localhorst04 wants to merge 1 commit intoAxionAOSP:lineage-23.2from
Localhorst04:lineage-23.2

Conversation

@Localhorst04
Copy link
Copy Markdown

@Localhorst04 Localhorst04 commented Apr 25, 2026

  • bug preview in builders group (too big to upload here)

  • Tested by using it, might require cleaning up/logging to make sure no regressions have been made

Change-Id: I7f7ba49c692a7fefb81ce22a4f67dd5a804675e7

@Localhorst04
[SystemUI] fix custom UDFPS animation getting stuck
8612d3c 
Custom UDFPS animations are driven by their own overlay and interactor
state. If authentication completes before a normal touch-up callback is
dispatched, the animation can keep its pressed state and continue looping
on keyguard/AOD.

Add an explicit stop path for the animation state and clear it when UDFPS
capture completes, when the keyguard overlay is hidden, and when a
fingerprint auth failure is reported.

Change-Id: I7f7ba49c692a7fefb81ce22a4f67dd5a804675e7
@Localhorst04
Copy link
Copy Markdown
Author

Localhorst04 commented Apr 25, 2026 •
edited
Loading

Notes:

  • Not sure if adding a whole KeyguardMonitorCallback was the right choice here but it seems to do its job - which is stopping the animation on unsuccessful FP scans too.

  • the stopAnimation() is just for semantics.
    onAcquired() is a fingerprint acquisition callback and hideUdfpsOverlay() is overlay lifecycle cleanup.. neither represents the user lifting their finger. They
    only need to stop the custom animation, while real touch-up handling still
    flows through onFingerUp().

@Localhorst04
Copy link
Copy Markdown
Author

Localhorst04 commented Apr 25, 2026

Noticed a bad issue, will fix that and do a new PR or reopen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Localhorst04