feat: add a new MissingWord LintKind - #4007
Open
hippietrail wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
N/A
Description
I was looking at a linter that inserts a missing word and realized that none of the
LintKinds really fit, usuallyUsageis the closest. But we've now got easily enough linters adding missing words to warrant a newMissingWordLintKind.This PR converts all the linters I could identify that add a missing word, whether that be always or only on some logic paths.
I also found an opportunity to make the
LintKindcode a little bit more DRY, and I found a debug-printf that accidentally slipped through.I'm less that fully fluent in some of the web and desktop code that does things such as grouping
LintKinds together, so would appreciate people reviewing those parts.How Has This Been Tested?
cargo testAI Disclosure
Checklist