Repository navigation
test(php-transformer): run timing-ratio tests alone after the parallel batch - #5267
Merged
Merged
Conversation
…l batch gallery-compilation-scaling failed on PHP 8.2 CI after #5244 because it compared its own timings while sharing four cores with other tests. The three *-scaling.php tests now run one at a time once the parallel batch finishes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After #5244,
gallery-compilation-scalingfailed in trunk's PHP 8.2 job (run forb8d2b5f1). The test compares its own timings across input sizes, and in that run it shared a 4-core runner with tests likecaptured-interaction-page-budget, which took 1,086s on 8.2. Three tests assert timing ratios, and all three are named*-scaling.php:gallery-compilation-scalingrecognizer-compilation-scalingroute-selector-match-index-scalingChange
tests/run.phpruns the*-scaling.phpfiles one at a time after the parallel batch finishes, so each measures its own timings on an otherwise idle machine. The scheduling loop moved into arun_tests($tests, $jobs)function that both phases share.Verification
On homeboy-lab with
php tests/run.php --jobs=4(CI's core count): 1,312 tests, 0 failures, 149s wall.AI disclosure: Claude Opus (Anthropic) via Pi/Roadie diagnosed the failure and made this change for Chris Huber.