Repository navigation
refactor(php-transformer): move inline flow lowering into Elements/InlineFlowLowering - #5258
Merged
Merged
Conversation
…lineFlowLowering Moves textFlowBlockFromElement and inlineTokenGroupBlockFromElement out of HtmlCompilation verbatim. The token-group recursion goes through the PatternTreeConverter, as in the other lowering owners.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4368 (slice 2x).
What
Elements/InlineFlowLowering. Moved verbatim out ofHtmlCompilation:textFlowBlockFromElement: a div of inline content split by<br>becomes one paragraph.inlineTokenGroupBlockFromElement: an inline token group becomes a group of paragraphs.SourceDom::attrreplaces the trait forward.$this->blocks->createBlock.$this->tree->element(), thePatternTreeConvertersubstitution from refactor(php-transformer): give lowering owners the PatternTreeConverter instead of recursion closures #5183. Every reader of$fallbackscounts relative to its own starting length, so the local-then-merge form gives the same result.HtmlCompilation: −85 lines.Verification
composer validate --strict && lint && test:lint && test):GATE=0.rj/websitecompile, trunk2b7024f6vs this branch44f23281, with HEADs asserted:output_sha2563621947c…e51fon all 4 outputs, byte-identical.AI disclosure: Claude Opus (Anthropic) via Pi/Roadie moved the code with a mechanical mover script, ran the Lab gate and A/B, and wrote this PR for Chris Huber.