Repository navigation
fix(js): declare the Node 22.13 floor pnpm 11 requires - #2143
Merged
Merged
Conversation
The package pins pnpm@11.14.0, which requires Node >=22.13, but declared engines.node >=20. Release tooling now derives the Node version from engines, so it installed Node 20 and pnpm failed to start.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JavaScript component's release now fails while enabling its package manager (run 35829327317):
packages/blocks-engine/package.jsonpinspnpm@11.14.0, which requiresnode >=22.13(per its publishedengines), but declaresengines.node: ">=20". Release tooling derives the Node version fromengines.node(Extra-Chill/homeboy-extensions#2873), so it correctly installed the declared floor, Node 20, and pnpm 11 cannot start on it.The package's own JS CI already runs Node 22 (
js.yml), which is why this was never visible there. The declaration had fallen behind the toolchain. This raises it to>=22.13, matching what pnpm 11 needs.Verified:
AI disclosure: diagnosed, fixed, and described by Claude (claude-sonnet-4-6) via Claude Code, acting for Chris Huber.