Repository navigation
feat(dialog): add option to stack dialog buttons vertically - #3195
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
settings.registration.dialog.stackButtonsVertically, disabled by default, which shows dialog buttons in a single column with the primary button on top. Existing servers keep the current side-by-side layout.Stacking keeps the existing tab order, so Tab from the last input still reaches the primary button first. Swapping the buttons horizontally would make Tab + Enter activate Cancel first, because the client's tab order follows the button order.
The option applies to the pre-join and post-join dialogs through
DialogWindowSpec. Dialogs with a single button look the same either way.Testing:
DialogWindowServiceTest: the option is kept when a pre-join register dialog is shown again with an error, and disabled dialogs use two columns.SpigotDialogHelperTest: the login dialog uses one column when the option is enabled.mvn -V -B clean packageon JDK 21: build passes.Not tested in-game: Folia and Spigot.
Closes #3194