Skip to content

Migrate to oa-configurator 1.0 - #43

Draft
nicoloesch wants to merge 6 commits into
mainfrom
refactor-oa-config
Draft

Migrate to oa-configurator 1.0#43
nicoloesch wants to merge 6 commits into
mainfrom
refactor-oa-config

Conversation

@nicoloesch

@nicoloesch nicoloesch commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Depends on: orm-loader, must merge and publish first. Bumps pyproject.toml's oa-configurator pin (two locations: main deps, dev extra) once the new version is out. # TODO markers already in the diff.out.

Summary

  • Migrate OmopAlchemyConfig onto RefTo(DatabaseConfig): cdm_db/test_cdm_db fields replace CDM_DB/TEST_DB ResourceSpec objects and owned_resources/required_resources/test_resources.
    • test_cdm_db carries RefTo(DatabaseConfig, is_test=True)
    • the old, disconnected TEST_DB ClassVar is removed entirely due to redundancy
  • get_cdm_context()/create_cdm_engine()
    • resolver.resolve_resource()resolve_database();
    • resolved.database.urlresolved.connection.url (the renamed attribute on ResolvedDatabase).
  • maintenance/cli_schema_info.py
    • same resolve_resourceresolve_database fix
    • now resolves the database name via the package config instead of a hardcoded CDM_DB.semantic_name.
  • tests/conftest.py
    • resolve_test_resource(OmopAlchemyConfig.TEST_DB)resolve_test_database(OmopAlchemyConfig, "test_cdm_db")
    • removed pg_session check for test databases as that is now in oa-configurator
  • Fixed 5 test files still constructing StackConfig with the old databases=/resources= shape (DatabaseConfig-as-raw-connection, ResourceConfig)
  • connections=/databases= with ConnectionConfig/DatabaseConfig for all test files

Relationship to open PRs and issues

@nicoloesch nicoloesch added the breaking Incompatible API change. MAJOR: x+1.y.z label Aug 3, 2026
@gkennos

gkennos commented Aug 7, 2026

Copy link
Copy Markdown
Member

don't deploy this before a PR for #45 has been merged as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Incompatible API change. MAJOR: x+1.y.z

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Relax oa-configurator / orm-loader pins to semver ranges

2 participants