Implement staging table changes of orm-loader - #29
Merged
Conversation
nicoloesch
marked this pull request as ready for review
August 3, 2026 04:01
gkennos
self-requested a review
August 3, 2026 04:53
gkennos
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Replace staging-schema/search_path fallthrough with native orm_loader schema support #17
cli_vocab.py: staging schema isolation is now driven by orm-loader's backend rather than asearch_pathworkaround (see Overhauled staging tables with schemas and centralised specifiers orm-loader#22)ensure_schemais called forSTAGING_SCHEMAsearch_pathtodb_schemaonly (staging schema no longer needs to be on the path becauseorm-loaderqualifies staging identifiers explicitly).Guard added: raises
ValueErrorifdb_schema == STAGING_SCHEMAto prevent silent schema collision._is_missing_staging_table_errornow derives the staging table name viaresolve_backend(session).staging_name_for_table(model.__tablename__)instead of calling the removedmodel.staging_tablename()protocol method.