Skip to content

Fix remix contest submission count query #14352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cursor wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −5
Draft

Fix remix contest submission count query #14352

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions packages/common/src/api/tan-query/remixes/useRemixes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,10 +169,10 @@ export const useRemixes = (
}

/**
* Count-only companion to `useRemixes`. Hits the same SDK endpoint with
* `limit=0` and stores just the total under a separate query key so the
* lineup query can keep its standard `LineupData[]` page shape (which is
* what `TrackLineup` / `playFrom`'s `querySource` requires).
* Count companion to `useRemixes`. Hits the same SDK endpoint and stores
* just the total under a separate query key so the lineup query can keep
* its standard `LineupData[]` page shape (which is what `TrackLineup` /
* `playFrom`'s `querySource` requires).
*/
export const useRemixesCount = (
{ trackId, isCosign = false, isContestEntry = false }: UseRemixesCountArgs,
Expand All @@ -189,7 +189,11 @@ export const useRemixesCount = (
const remixesResponse = await sdk.tracks.getTrackRemixes({
trackId: Id.parse(trackId),
userId: OptionalId.parse(currentUserId),
limit: 0,
// Fetch one item so the count follows the same API path as the
// paginated remix list. Some nodes do not treat limit=0 as a
// reliable count-only request, which can make contest pages show
// "Submissions (0)" while the list below has entries.
limit: 1,
offset: 0,
onlyCosigns: isCosign,
onlyContestEntries: isContestEntry
Expand Down
Loading