Repository navigation
Let local and demo listen on loopback when run on a host (B05) - #20
Closed
AsyncAssassin wants to merge 1 commit into
Closed
AsyncAssassin wants to merge 1 commit into
AsyncAssassin wants to merge 1 commit into
Conversation
The quickstart starts local and demo with ./gradlew bootRun, and both listened on every interface: anyone on the same network could use local without credentials, and demo with its public passwords. Round 1 closed this for compose only. Both profiles now bind server.address to 127.0.0.1, which SERVER_ADDRESS overrides for a remote demo on a trusted network. The Docker image sets SERVER_ADDRESS=0.0.0.0, because a container is reached through its published port, which docker-compose.yml keeps on the host's loopback.
Owner
Author
|
Combined into #23 together with the other batch-1 fixes, so they merge without a rebase per PR. This description keeps the detailed evidence for its fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
B05 from the merged review of v0.4.0; 0.4.1 is released once all fixes are merged. The README quickstart starts
localanddemowith./gradlew bootRun, and both listened on every interface. Anyone on the same network could uselocalwithout credentials, anddemowith its published passwords. Round 1 closed this for compose only.application-local.ymlandapplication-demo.ymlsetserver.address: ${SERVER_ADDRESS:127.0.0.1}.SERVER_ADDRESS=0.0.0.0opens a remotedemoon a trusted network, and neverlocal.prodis unchanged.SERVER_ADDRESS=0.0.0.0. A container is reached through its published port, whichdocker-compose.ymlkeeps on the host's loopback, so compose works as before.The README environment table and remote-demo paragraph,
docs/architecture.md, anddocs/testing.mddescribe it.CHANGELOG.mdlists it under[Unreleased]→ Security.Verification
./gradlew clean check: 273 tests, 0 failures, 2 skipped (the env-gated Alchemy live smoke).LoopbackBindingIntegrationTestsbootslocalanddemoagainst its own PostgreSQL and reads the address Tomcat's connector is bound to. It is127.0.0.1for both, and0.0.0.0fordemowithSERVER_ADDRESS=0.0.0.0. Without the profile change the test fails, because the address is unset.Live,
lsofon the listening socket, themainjar against this branch:mainlocalwithjava -jar*:18202127.0.0.1:18202demowithjava -jar*:18202127.0.0.1:18202demowithSERVER_ADDRESS=0.0.0.0*:18202*:18202docker compose up --buildin the defaultlocalprofile, as its own compose project on spare ports: health answers200through the published127.0.0.1:18203, and the container runs withSERVER_ADDRESS=0.0.0.0.This PR and #15 to #19 each add a section under
[Unreleased]inCHANGELOG.md, so each later merge needs a one-file rebase. The other files merge cleanly with all of them; the new lines inapplication-demo.ymlsit at the top of the file, away from the lines #15 changes.