Fix ZeroDivisionError in Shapes._merge_shapes on zero-area groups - #376
Open
jaxorama wants to merge 1 commit into
Open
Fix ZeroDivisionError in Shapes._merge_shapes on zero-area groups#376jaxorama wants to merge 1 commit into
jaxorama wants to merge 1 commit into
Conversation
Shapes._merge_shapes() divides sum_area by merged_area to decide whether a group of same-color, overlapping shapes should be merged into one. Some real-world PDFs (e.g. containing degenerate zero-width border rectangles) produce a group whose merged bounding box has zero area, raising ZeroDivisionError and aborting the whole conversion. Guard the division so a zero-area group is simply left unmerged instead of crashing, and add a regression test using a minimal same-color, zero-area shape pair (no sample PDF needed to trigger it).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shapes._merge_shapes() divides sum_area by merged_area to decide whether a group of same-color, overlapping shapes should be merged into one. Some real-world PDFs (e.g. containing degenerate zero-width border rectangles) produce a group whose merged bounding box has zero area, raising ZeroDivisionError and aborting the whole conversion.
Guard the division so a zero-area group is simply left unmerged instead of crashing, and add a regression test using a minimal same-color, zero-area shape pair (no sample PDF needed to trigger it).