Skip to content

[PyGerber]: Some arcs cause render_with_shapely to fail #383

Description

@Trackmaniadude

PyGerber Bug Report

Mandatory checks

Before opening this issue:

  • I have reviewed the README for guidelines and haven't found a solution there.
  • I have reviewed the PyGerber documentation and haven't found a solution there.
  • I have reviewed the existing open issues and verified that this is not a
    duplicate.
  • I have reviewed the existing closed issues and verified that this was already
    resolved or marked as won't fix.
  • I have reviewed the existing pull requests and verified that this is not a already
    known issue.
  • I have reviewed the existing discussions and verified that this is not a already
    known issue.

To Reproduce

Load the attached file arctest2-F_Adhesive.txt and call GerberFile.from_file(file path).render_with_shapely()
(Wouldn't let me upload a .gbr, so i changed it to .txt)

Expected behavior

Render succeeds

Additional context

This seems to happen with any file generated by KiCad which contains a filled circle. Non-filled circles work fine.
Disabling the offending assert (or changing it from > to >=) doesn't seem to break things but does fix the issue.

Environment:

  • Operating system: [Windows 10]
  • Python version: [3.11]
  • PyGerber version: [latest dev]

Optional checks

  • I want to contribute example source files attached to this issue in the test suite
    of PyGerber for regression testing purposes.
  • I want to include separate LICENSE file for resource files attached as a result of
    an agreement described in first checkbox in this section.
  • I want to include separate README file for resource files attached as a result of
    an agreement described in first checkbox in this section.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingready-for-reproductionIssue is ready for reproduction after all required checkboxes was reported as acknowledged

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions