Feat/test coverage follow stats liquidity escrow#1257
Merged
Olowodarey merged 3 commits intoJun 29, 2026
Merged
Conversation
Add tests to verify that FlagsService.createFlag allows creating new flags after a previous flag has been resolved or dismissed. Confirms that duplicate check only applies to PENDING status. test(users): add getFollowStats endpoint and tests Add GET /users/:address/follow-stats public endpoint returning follower and following counts without the full lists. Includes FollowStatsResponseDto and comprehensive unit tests. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Add comprehensive test verifying that LP providers receive principal plus accumulated fees when removing liquidity. Confirms fee collection works correctly and pool is empty after full removal. test(escrow): add test for assert_escrow_solvent underfunding detection Add test verifying that assert_escrow_solvent correctly detects when contract balance falls below outstanding obligations and can verify restoration. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
- Add createQueryBuilder mock to UserFollow repository mock - Update test assertions to match actual error messages - Fix test error messages to use NotFoundException class instead of string Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@strngecloud Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Summary
This PR addresses four GitHub issues by adding comprehensive tests and a new public API endpoint for user follow statistics.
Issues Closed
FlagsService.createFlagallows re-flagging after a flag is resolved #1159GET /users/:address/follow-statsfollower and following count #1161remove_liquidityreturns principal plus accumulated fees #1046assert_escrow_solventdetects underfunding #1058Changes
Backend - Flags Service (#1159)
FlagsService.createFlagallows re-flagging after a flag is resolved or dismissedPENDINGstatusBackend - Users Service (#1161)
FollowStatsResponseDtofor lightweight follower/following countsgetFollowStatsmethod inUsersServiceGET /users/:address/follow-statspublic endpoint toUsersControllerSmart Contracts - Liquidity (#1046)
collect_lp_feesbefore removalSmart Contracts - Escrow (#1058)
assert_escrow_solventdetects underfundingTesting